[gcr] system-prompt: Fix racy segfault when prompter dismissed immediately



commit f25cc328066e7b6a7f960aea38ab6beb6f967a42
Author: Stef Walter <stefw gnome org>
Date:   Sun Mar 17 21:38:14 2013 +0100

    system-prompt: Fix racy segfault when prompter dismissed immediately
    
    When the prompter (like gnome-shell) dismisses a prompt immediately
    there was a case when gcr would dereference a NULL pointer.

 gcr/gcr-system-prompt.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
---
diff --git a/gcr/gcr-system-prompt.c b/gcr/gcr-system-prompt.c
index b370b1c..25c6cd9 100644
--- a/gcr/gcr-system-prompt.c
+++ b/gcr/gcr-system-prompt.c
@@ -670,7 +670,6 @@ prompt_method_ready (GcrSystemPrompt *self,
 
        res = g_object_ref (self->pv->pending);
        g_clear_object (&self->pv->pending);
-       g_simple_async_result_set_op_res_gpointer (res, NULL, NULL);
        g_simple_async_result_complete (res);
        g_object_unref (res);
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]