[gtksourceview/wip/completion: 2/4] Completion: remove debug messages



commit 3f4fb71c47a439e26b3a1454f1135cf2941922ba
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Sun Mar 10 22:52:49 2013 +0100

    Completion: remove debug messages
    
    I personaly use gdb, or I sometimes add temporary g_message()s at
    very specific places. Those specific places change for each bug. IMHO
    it's not useful to keep the debug messages.

 gtksourceview/gtksourcecompletion.c |   39 -----------------------------------
 1 files changed, 0 insertions(+), 39 deletions(-)
---
diff --git a/gtksourceview/gtksourcecompletion.c b/gtksourceview/gtksourcecompletion.c
index f2e0160..b897442 100644
--- a/gtksourceview/gtksourcecompletion.c
+++ b/gtksourceview/gtksourcecompletion.c
@@ -93,15 +93,6 @@
                                                  GTK_SOURCE_TYPE_COMPLETION,           \
                                                  GtkSourceCompletionPrivate))
 
-/*#define ENABLE_DEBUG*/
-#undef ENABLE_DEBUG
-
-#ifdef ENABLE_DEBUG
-#define DEBUG(x) (x)
-#else
-#define DEBUG(x)
-#endif
-
 /* Signals */
 enum
 {
@@ -1237,10 +1228,6 @@ update_completion (GtkSourceCompletion        *completion,
        GList *providers_copy = g_list_copy (providers);
        GtkSourceCompletionContext *context_copy = g_object_ref_sink (context);
 
-       DEBUG({
-               g_print ("Update completion: %d\n", g_list_length (providers));
-       });
-
        /* Make sure to first cancel any running completion */
        reset_completion (completion);
 
@@ -1255,13 +1242,6 @@ update_completion (GtkSourceCompletion        *completion,
        for (item = providers_copy; item != NULL; item = g_list_next (item))
        {
                GtkSourceCompletionProvider *provider = item->data;
-
-               DEBUG({
-                       gchar *temp_name = gtk_source_completion_provider_get_name (provider);
-                       g_print ("Populating provider: %s\n", temp_name);
-                       g_free (temp_name);
-               });
-
                gtk_source_completion_provider_populate (provider, context_copy);
        }
 
@@ -1388,10 +1368,6 @@ populating_done (GtkSourceCompletion        *completion,
 {
        if (gtk_source_completion_model_is_empty (completion->priv->model_proposals, TRUE))
        {
-               DEBUG({
-                       g_print ("Model is empty after populating\n");
-               });
-
                gtk_source_completion_hide (completion);
                return;
        }
@@ -1403,18 +1379,8 @@ populating_done (GtkSourceCompletion        *completion,
 
        if (!gtk_widget_get_visible (GTK_WIDGET (completion->priv->main_window)))
        {
-               DEBUG({
-                       g_print ("Emitting show\n");
-               });
-
                g_signal_emit (completion, signals[SHOW], 0);
        }
-       else
-       {
-               DEBUG({
-                       g_print ("Already visible\n");
-               });
-       }
 
        check_first_selected (completion);
 }
@@ -2337,11 +2303,6 @@ gtk_source_completion_show (GtkSourceCompletion        *completion,
        if (selected_providers == NULL)
        {
                g_object_unref (context);
-
-               DEBUG({
-                       g_print ("No providers for completion\n");
-               });
-
                gtk_source_completion_hide (completion);
                return FALSE;
        }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]