[gnome-weather] Temporarily import package and params modules
- From: Giovanni Campagna <gcampagna src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-weather] Temporarily import package and params modules
- Date: Sat, 9 Mar 2013 11:38:03 +0000 (UTC)
commit d231612f50622b4c0d2bbef83b4cac7c1e3f4e4c
Author: Giovanni Campagna <gcampagna src gnome org>
Date: Mon Mar 4 17:33:07 2013 +0100
Temporarily import package and params modules
This allows gnome-weather to run without the new gjs API.
Unfortunately, as a side effect you need to install the application
to try it, running gnome-weather from the source tree no longer works.
Cherry-picked to master because it is not clear if the new gjs
API will be ever merged upstream.
src/Makefile.am | 13 ++-
src/gnome-weather.in | 4 +-
src/main.js | 6 +-
src/package.js | 282 ++++++++++++++++++++++++++++++++++++++++++++++++++
src/params.js | 128 +++++++++++++++++++++++
5 files changed, 427 insertions(+), 6 deletions(-)
---
diff --git a/src/Makefile.am b/src/Makefile.am
index 16a46ca..c05cc00 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -7,14 +7,23 @@ dist_js_DATA = \
city.js \
forecast.js \
main.js \
+ package.js \
+ params.js \
strings.js \
util.js \
window.js \
world.js \
$(NULL)
-gnome-weather: $(top_builddir)/config.status gnome-weather.in
- $(AM_V_GEN) cd $(top_builddir) && $(SHELL) ./config.status --file $(subdir)/$@
+gnome-weather: gnome-weather.in
+ $(AM_V_GEN) sed \
+ -e "s|[ ]GJS@|$(GJS)|g" \
+ -e "s|[ ]PACKAGE_NAME@|$(PACKAGE_NAME)|g" \
+ -e "s|[ ]PACKAGE_VERSION@|$(PACKAGE_VERSION)|g" \
+ -e "s|[ ]prefix@|$(prefix)|g" \
+ -e "s|[ ]libdir@|$(libdir)|g" \
+ -e "s|[ ]pkgdatadir@|$(pkgdatadir)|g" \
+ $< > $@
@chmod +x $@
EXTRA_DIST = gnome-weather.in
diff --git a/src/gnome-weather.in b/src/gnome-weather.in
index 7dba173..599e93d 100755
--- a/src/gnome-weather.in
+++ b/src/gnome-weather.in
@@ -1,5 +1,7 @@
#! GJS@
+imports.searchPath.push("@pkgdatadir@");
imports.package.start({ name: "@PACKAGE_NAME@",
version: "@PACKAGE_VERSION@",
- prefix: "@prefix@" });
+ prefix: "@prefix@",
+ libdir: "@libdir@" });
diff --git a/src/main.js b/src/main.js
index 6783e6b..8435071 100644
--- a/src/main.js
+++ b/src/main.js
@@ -27,10 +27,10 @@ pkg.require({ 'Gd': '1.0',
'GObject': '2.0',
'Gtk': '3.0',
'GWeather': '3.0',
- 'Lang': '1.0',
- 'Mainloop': '1.0',
+ 'Lang': '',
+ 'Mainloop': '',
'Params': '1.0',
- 'System': '1.0' });
+ 'System': '' });
const Util = imports.util;
const Window = imports.window;
diff --git a/src/package.js b/src/package.js
new file mode 100644
index 0000000..67d98d1
--- /dev/null
+++ b/src/package.js
@@ -0,0 +1,282 @@
+// Copyright 2012 Giovanni Campagna
+//
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to
+// deal in the Software without restriction, including without limitation the
+// rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+// sell copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+//
+// The above copyright notice and this permission notice shall be included in
+// all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+// IN THE SOFTWARE.
+
+/**
+ * This module provides a set of convenience APIs for building packaged
+ * applications.
+ */
+
+const GLib = imports.gi.GLib;
+const GIRepository = imports.gi.GIRepository;
+const System = imports.system;
+
+const Gettext = imports.gettext;
+
+/*< public >*/
+var name;
+var version;
+var prefix;
+var datadir;
+var libdir;
+var pkgdatadir;
+var pkglibdir;
+var moduledir;
+var localedir;
+
+/*< private >*/
+let _base;
+let _requires;
+
+/**
+ * init:
+ * @params: package parameters
+ *
+ * Initialize directories and global variables. Must be called
+ * before any of other API in Package is used.
+ * @params must be an object with at least the following keys:
+ * - name: the package name ($(PACKAGE_NAME) in autotools)
+ * - version: the package version
+ * - prefix: the installation prefix
+ *
+ * init() will take care to check if the program is running from
+ * the source directory or not, by looking for a 'src' directory.
+ *
+ * At the end, the global variable 'pkg' will contain the
+ * Package module (imports.package). Additionally, the following
+ * module variables will be available:
+ * - name, version: same as in @params
+ * - prefix: the installation prefix (as passed in @params)
+ * - datadir, libdir: the final datadir and libdir when installed;
+ * usually, these would be prefix + '/share' and
+ * and prefix + '/lib' (or '/lib64')
+ * - pkgdatadir: the directory to look for private data files, such as
+ * images, stylesheets and UI definitions;
+ * this will be datadir + name when installed and
+ * './data' when running from the source tree
+ * - pkglibdir: the directory to look for private typelibs and C
+ * libraries;
+ * this will be libdir + name when installed and
+ * './lib' when running from the source tree
+ * - moduledir: the directory to look for JS modules;
+ * this will be pkglibdir when installed and
+ * './src' when running from the source tree
+ * - localedir: the directory containing gettext translation files;
+ * this will be datadir + '/locale' when installed
+ * and './po' in the source tree
+ *
+ * All paths are absolute and will not end with '/'.
+ *
+ * As a side effect, init() calls GLib.set_prgname().
+ */
+function init(params) {
+ window.pkg = imports.package;
+ name = params.name;
+ version = params.version;
+
+ // Must call it first, because it can only be called
+ // once, and other library calls might have it as a
+ // side effect
+ GLib.set_prgname(name);
+
+ prefix = params.prefix;
+ libdir = params.libdir;
+ datadir = GLib.build_filenamev([prefix, 'share']);
+ let libpath, girpath;
+
+ if (GLib.file_test('./src',
+ GLib.FileTest.IS_DIR)) {
+ log('Running from source tree, using local files');
+ // Running from source directory
+ _base = GLib.get_current_dir();
+ pkglibdir = GLib.build_filenamev([_base, 'lib']);
+ libpath = GLib.build_filenamev([pkglibdir, '.libs']);
+ girpath = pkglibdir;
+ pkgdatadir = GLib.build_filenamev([_base, 'data']);
+ localedir = GLib.build_filenamev([_base, 'po']);
+ moduledir = GLib.build_filenamev([_base, 'src']);
+ } else {
+ _base = prefix;
+ pkglibdir = GLib.build_filenamev([libdir, name]);
+ libpath = pkglibdir;
+ girpath = GLib.build_filenamev([pkglibdir, 'girepository-1.0']);
+ pkgdatadir = GLib.build_filenamev([datadir, name]);
+ localedir = GLib.build_filenamev([datadir, 'locale']);
+ moduledir = pkgdatadir;
+ }
+
+ imports.searchPath.push(moduledir);
+ GIRepository.Repository.prepend_search_path(girpath);
+ GIRepository.Repository.prepend_library_path(libpath);
+}
+
+/**
+ * start:
+ * @params: see init()
+ *
+ * This is a convenience function if your package has a
+ * single entry point.
+ * You must define a main(ARGV) function inside a main.js
+ * module in moduledir.
+ */
+function start(params) {
+ init(params);
+
+ return imports.main.main(ARGV);
+}
+
+function _checkVersion(required, current) {
+ if (required == '') {
+ // No requirement
+ return true;
+ }
+
+ // Major version must match, it's used for API
+ // incompatible changes.
+ // The rest just needs to be less or equal to
+ // current. The code is generic, but gjs modules
+ // should use only [major, minor]
+ if (required[0] != current[0])
+ return false;
+
+ for (let i = 1; i < Math.min(current.length, required.length); i++) {
+ if (required[i] > current[i])
+ return false;
+ if (required[i] < current[i])
+ return true;
+
+ // else they're equal, go on
+ }
+
+ return true;
+}
+
+function _isGjsModule(name, version) {
+ // This is a subset of the JS modules we offer,
+ // it includes only those that makes sense to use
+ // standalone and in a general app.
+ //
+ // You will not find Gettext or Format here, use
+ // the package functions instead. And Package, obviously,
+ // because it's available as window.package.
+ //
+ // cairo is also a JS module, but the version checking
+ // differs, see _isForeignModule()
+ //
+ // FIXME: Mainloop might be better as a GLib override?
+ // FIXME: Signals should be an extension to Lang
+ const RECOGNIZED_MODULE_NAMES = ['Lang',
+ 'Mainloop',
+ 'Signals',
+ 'System',
+ 'Params'];
+ for (let i = 0; i < RECOGNIZED_MODULE_NAMES.length; i++) {
+ let module = RECOGNIZED_MODULE_NAMES[i];
+
+ if (module == name) {
+ let actualModule = imports[module.toLowerCase()];
+ let required = version.split('.');
+
+ if (!_checkVersion(required, actualModule.$API_VERSION)) {
+ printerr('Unsatisfied dependency: requested GJS module at version '
+ + version + ', but only ' + (actualModule.$API_VERSION.join('.'))
+ + ' is available');
+ System.exit(1);
+ } else {
+ window[module] = actualModule;
+ return true;
+ }
+ }
+ }
+
+ return false;
+}
+
+/**
+ * require:
+ * @libs: the external dependencies to import
+ *
+ * Mark a dependency on a specific version of one or more
+ * external GI typelibs.
+ * @libs must be an object whose keys are a typelib name,
+ * and values are the respective version. The empty string
+ * indicates any version.
+ *
+ * If dependencies are statisfied, require() will make
+ * the module objects available as global names.
+ */
+function require(libs) {
+ _requires = libs;
+
+ for (let l in libs) {
+ let version = libs[l];
+
+ if (_isGjsModule(l, version))
+ continue;
+
+ if (version != '')
+ imports.gi.versions[l] = version;
+
+ try {
+ if (name == 'cairo') {
+ // Import the GI package to check the version,
+ // but then load the JS one
+ imports.gi.cairo;
+ window.cairo = imports.cairo;
+ } else {
+ window[l] = imports.gi[l];
+ }
+ } catch(e) {
+ printerr('Unsatisfied dependency: ' + e.message);
+ System.exit(1);
+ }
+ }
+}
+
+function dumpRequires() {
+ print(JSON.stringify(_requires));
+}
+
+function initGettext() {
+ Gettext.bindtextdomain(name, localedir);
+ Gettext.textdomain(name);
+
+ let gettext = imports.gettext;
+ window._ = gettext.gettext;
+ window.C_ = gettext.pgettext;
+ window.N_ = function(x) { return x; }
+}
+
+function initFormat() {
+ let format = imports.format;
+ String.prototype.format = format.format;
+}
+
+function initSubmodule(name) {
+ if (moduledir != pkgdatadir) {
+ // Running from source tree, add './name' to search paths
+
+ let submoduledir = GLib.build_filenamev([_base, name]);
+ let libpath = GLib.build_filenamev([submoduledir, '.libs']);
+ GIRepository.Repository.prepend_search_path(submoduledir);
+ GIRepository.Repository.prepend_library_path(libpath);
+ } else {
+ // Running installed, submodule is in $(pkglibdir), nothing to do
+ }
+}
diff --git a/src/params.js b/src/params.js
new file mode 100644
index 0000000..4b8e1c4
--- /dev/null
+++ b/src/params.js
@@ -0,0 +1,128 @@
+// -*- mode: js; js-indent-level: 4; indent-tabs-mode: nil -*-
+
+// Rules for versioning: bump major when making API incompatible changes,
+// bump minor when adding API
+var $API_VERSION = [1, 0];
+
+// Params:
+//
+// A set of convenience functions for dealing with pseudo-keyword
+// arguments.
+//
+// Examples:
+//
+// A function with complex arguments
+// function myFunction(params) {
+// params = Params.parse(params, { myFlags: Flags.NONE,
+// anInt: 42,
+// aString: 'hello, world!',
+// });
+// ... params.anInt, params.myFlags, params.aString ...
+// }
+// myFunction({ anInt: -1 });
+//
+// Extend a method to allow more params in a subclass
+// The superclass can safely use Params.parse(), it won't see
+// the extensions.
+// const MyClass = new Lang.Class({
+// ...
+// method: function(params) {
+// let mine = Params.filter(params, { anInt: 42 });
+// this.parent(params);
+// ... mine.anInt ...
+// }
+// });
+
+// parse:
+// @params: caller-provided parameter object, or %null
+// @defaults: function-provided defaults object
+//
+// Examines @params and fills in default values from @defaults for
+// any properties in @defaults that don't appear in @params.
+// This function will throw a Error if @params contains a property
+// that is not recognized. Use fill() or filter() if you don't
+// want that.
+//
+// If @params is %null, this returns the values from @defaults.
+//
+// Return value: a new object, containing the merged parameters from
+// @params and @defaults
+function parse(params, defaults) {
+ let ret = {}, prop;
+ params = params || {};
+
+ for (prop in params) {
+ if (!(prop in defaults))
+ throw new Error('Unrecognized parameter "' + prop + '"');
+ ret[prop] = params[prop];
+ }
+
+ for (prop in defaults) {
+ if (!(prop in params))
+ ret[prop] = defaults[prop];
+ }
+
+ return ret;
+}
+
+// fill:
+// @params: caller-provided parameter object, or %null
+// @defaults: function-provided defaults object
+//
+// Examines @params and fills in default values from @defaults
+// for any properties in @defaults that don't appear in @params.
+//
+// Differently from parse(), this function does not throw for
+// unrecognized parameters.
+//
+// Return value: a new object, containing the merged parameters from
+// @params and @defaults
+function fill(params, defaults) {
+ let ret = {};
+ params = params || {};
+
+ for (prop in params)
+ ret[prop] = params[prop];
+
+ for (prop in defaults) {
+ if (!(prop in ret))
+ ret[prop] = defaults[prop];
+ }
+
+ return ret;
+}
+
+// filter:
+// @params: caller-provided parameter object, or %null
+// @defaults: function-provided defaults object
+//
+// Examines @params and returns an object containing the
+// same properties as @defaults, but with values taken from
+// @params where available.
+// Then it removes from @params all matched properties.
+//
+// This is similar to parse(), but it accepts unknown properties
+// and modifies @params for known ones.
+//
+// If @params is %null, this returns the values from @defaults.
+//
+// Return value: a new object, containing the merged parameters from
+// @params and @defaults
+function filter(params, defaults) {
+ let ret = {}, prop;
+ params = params || {};
+
+ for (prop in defaults) {
+ if (!(prop in params))
+ ret[prop] = defaults[prop];
+ }
+
+ for (prop in params) {
+ if (prop in defaults) {
+ ret[prop] = params[prop];
+ delete params[prop];
+ }
+ }
+
+ return ret;
+}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]