[easytag] Improve GtkEntry sizes in tags notebook
- From: David King <davidk src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [easytag] Improve GtkEntry sizes in tags notebook
- Date: Fri, 1 Mar 2013 21:01:03 +0000 (UTC)
commit a36cc1a5c7065569518b72414b289c60afbd6762
Author: David King <amigadave amigadave com>
Date: Fri Mar 1 20:56:37 2013 +0000
Improve GtkEntry sizes in tags notebook
Especially in GTK+ 3, the tab notebook could take up far too much
vertical space. Setting the size request of GtkEntry with
gtk_entry_set_width_chars() produces a better result than hardcoding the
pixel widths, as was done previously. Thanks to Arnd for noticing the
problem:
https://mail.gnome.org/archives/easytag-list/2013-March/msg00004.html
src/easytag.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/src/easytag.c b/src/easytag.c
index 92d6603..1df6c06 100644
--- a/src/easytag.c
+++ b/src/easytag.c
@@ -628,7 +628,6 @@ Create_Tag_Area (void)
TitleEntry = gtk_entry_new();
et_grid_attach_full (GTK_GRID (Table), TitleEntry, 1, 0, 9, 1, TRUE, TRUE,
TablePadding, TablePadding);
- gtk_widget_set_size_request(TitleEntry, 150, -1);
TitleMButton = gtk_button_new();
gtk_widget_set_size_request(TitleMButton,MButtonSize,MButtonSize);
@@ -711,7 +710,7 @@ Create_Tag_Area (void)
DiscNumberEntry = gtk_entry_new();
et_grid_attach_full (GTK_GRID (Table), DiscNumberEntry, 9, 3, 1, 1, TRUE,
TRUE, TablePadding, TablePadding);
- gtk_widget_set_size_request(DiscNumberEntry,30,-1);
+ gtk_entry_set_width_chars (GTK_ENTRY (DiscNumberEntry), 1);
// FIX ME should allow to type only something like : 1/3
//g_signal_connect(G_OBJECT(GTK_ENTRY(DiscNumberEntry)),"insert_text",G_CALLBACK(Insert_Only_Digit),NULL);
@@ -736,7 +735,7 @@ Create_Tag_Area (void)
gtk_entry_set_max_length(GTK_ENTRY(YearEntry), 4);
et_grid_attach_full (GTK_GRID (Table), YearEntry, 1, 4, 1, 1, TRUE, TRUE,
TablePadding, TablePadding);
- gtk_widget_set_size_request(YearEntry,37,-1);
+ gtk_entry_set_width_chars (GTK_ENTRY (YearEntry), 4);
g_signal_connect(G_OBJECT(YearEntry),"insert_text",G_CALLBACK(Insert_Only_Digit),NULL);
g_signal_connect(G_OBJECT(YearEntry),"activate",G_CALLBACK(Parse_Date),NULL);
g_signal_connect(G_OBJECT(YearEntry),"focus-out-event",G_CALLBACK(Parse_Date),NULL);
@@ -785,7 +784,8 @@ Create_Tag_Area (void)
TRUE, TablePadding, TablePadding);
gtk_combo_box_set_wrap_width(GTK_COMBO_BOX(TrackEntryCombo),3); // Three columns to display track
numbers list
- gtk_widget_set_size_request(TrackEntryCombo,50,-1);
+ gtk_entry_set_width_chars (GTK_ENTRY (gtk_bin_get_child (GTK_BIN (TrackEntryCombo))),
+ 2);
g_signal_connect(G_OBJECT(GTK_ENTRY(gtk_bin_get_child(GTK_BIN(TrackEntryCombo)))),"insert_text",
G_CALLBACK(Insert_Only_Digit),NULL);
@@ -810,7 +810,7 @@ Create_Tag_Area (void)
TrackTotalEntry = gtk_entry_new();
et_grid_attach_full (GTK_GRID (Table), TrackTotalEntry, 9, 4, 1, 1, TRUE,
TRUE, TablePadding, TablePadding);
- gtk_widget_set_size_request(TrackTotalEntry,30,-1);
+ gtk_entry_set_width_chars (GTK_ENTRY (TrackTotalEntry), 2);
g_signal_connect(G_OBJECT(GTK_ENTRY(TrackTotalEntry)),"insert_text",
G_CALLBACK(Insert_Only_Digit),NULL);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]