[gjs] keep-alive: Fix an unpaired BeginRequest / EndRequest



commit b99e50465c82e6b57af8d611a74985cc659c6904
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Mon Jun 24 20:19:18 2013 -0400

    keep-alive: Fix an unpaired BeginRequest / EndRequest
    
    And fix an atrociously bad cast error.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=703068

 gi/keep-alive.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/gi/keep-alive.c b/gi/keep-alive.c
index 415023f..4cb2a8d 100644
--- a/gi/keep-alive.c
+++ b/gi/keep-alive.c
@@ -179,7 +179,7 @@ JSObject*
 gjs_keep_alive_new(JSContext *context)
 {
     KeepAlive *priv;
-    JSObject *keep_alive;
+    JSObject *keep_alive = NULL;
     JSObject *global;
     JSBool found;
 
@@ -198,7 +198,8 @@ gjs_keep_alive_new(JSContext *context)
     g_assert(global != NULL);
 
     if (!JS_HasProperty(context, global, gjs_keep_alive_class.name, &found))
-        return JS_FALSE;
+        goto out;
+
     if (!found) {
         JSObject *prototype;
 
@@ -254,6 +255,7 @@ gjs_keep_alive_new(JSContext *context)
     gjs_debug_lifecycle(GJS_DEBUG_KEEP_ALIVE,
                         "keep_alive constructor, obj %p priv %p", keep_alive, priv);
 
+ out:
     JS_EndRequest(context);
 
     return keep_alive;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]