[ekiga] Added a few FIXME in the gtk+ frontend and main window code
- From: Julien Puydt <jpuydt src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [ekiga] Added a few FIXME in the gtk+ frontend and main window code
- Date: Fri, 21 Jun 2013 19:46:24 +0000 (UTC)
commit 30bf86bdcaa22de37c644292871e7d2cb200e84e
Author: Julien Puydt <jpuydt free fr>
Date: Thu Jun 20 21:59:39 2013 +0200
Added a few FIXME in the gtk+ frontend and main window code
lib/engine/gui/gtk-frontend/gtk-frontend.cpp | 2 ++
lib/engine/gui/gtk-frontend/main_window.cpp | 6 +++++-
2 files changed, 7 insertions(+), 1 deletions(-)
---
diff --git a/lib/engine/gui/gtk-frontend/gtk-frontend.cpp b/lib/engine/gui/gtk-frontend/gtk-frontend.cpp
index c9dc620..4cbccb6 100644
--- a/lib/engine/gui/gtk-frontend/gtk-frontend.cpp
+++ b/lib/engine/gui/gtk-frontend/gtk-frontend.cpp
@@ -179,6 +179,8 @@ GtkFrontend::build ()
boost::shared_ptr<GtkWidget> (preferences_window_new (core), gtk_widget_destroy);
// BEWARE: the status icon needs the chat window at startup
+ // FIXME: the above BEWARE is related to a FIXME in the main window code,
+ // FIXME: hence should disappear with it
status_icon =
boost::shared_ptr<StatusIcon> (status_icon_new (core), g_object_unref);
g_signal_connect (status_icon.get (), "clicked",
diff --git a/lib/engine/gui/gtk-frontend/main_window.cpp b/lib/engine/gui/gtk-frontend/main_window.cpp
index 5b99fef..0bb6cfd 100644
--- a/lib/engine/gui/gtk-frontend/main_window.cpp
+++ b/lib/engine/gui/gtk-frontend/main_window.cpp
@@ -1555,7 +1555,8 @@ ekiga_main_window_connect_engine_signals (EkigaMainWindow *mw)
mw->priv->connections.add (conn);
// FIXME: here we should watch for updates of the presence core
- // and call on_some_core_updated... it it had such a signal!
+ // FIXME: and call on_some_core_updated... if it had such a signal!
+ // FIXME: (that is about updating the menu of possible actions)
conn = mw->priv->contact_core->updated.connect (boost::bind (&on_some_core_updated, mw));
mw->priv->connections.add (conn);
}
@@ -1600,6 +1601,9 @@ gm_main_window_new (Ekiga::ServiceCore & core)
// initial population
on_some_core_updated (mw);
+ // FIXME: what does it do inside the main window if it's all about
+ // FIXME: the chat window and the audio output core!?
+
/* initialize the callback to play IM message sound */
boost::shared_ptr<GtkFrontend> gtk_frontend = mw->priv->gtk_frontend.lock ();
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]