[evolution-ews] Fix leaks in EWS_PTYP_MULTIPLEBINARY and multiple string handling



commit 5caaa450dd5777751ea772d0d003374899d8934f
Author: David Woodhouse <David Woodhouse intel com>
Date:   Mon Jun 10 23:45:54 2013 +0100

    Fix leaks in EWS_PTYP_MULTIPLEBINARY and multiple string handling
    
    We weren't actually adding parsed values to the list.
    Or returning said list, for that matter.
    
    And let's fix just *one* of the 'if (*error)' instances while we're at it...

 src/addressbook/ews-oab-decoder.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
---
diff --git a/src/addressbook/ews-oab-decoder.c b/src/addressbook/ews-oab-decoder.c
index c6c53b5..c2bdf62 100644
--- a/src/addressbook/ews-oab-decoder.c
+++ b/src/addressbook/ews-oab-decoder.c
@@ -715,14 +715,17 @@ ews_decode_oab_prop (EwsOabDecoder *eod,
                                                val = ews_oab_read_upto (G_INPUT_STREAM (priv->fis), '\0', 
cancellable, error);
                                        }
 
-                                       if (*error) {
+                                       if (!val) {
                                                g_slist_foreach (list, (GFunc) g_free, NULL);
                                                g_slist_free (list);
                                                return NULL;
                                        }
+
+                                       list = g_slist_prepend (list, val);
                                }
 
                        }
+                       ret_val = list;
 
                        break;
                }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]