[evolution-ews] Remove bogus comment and fix leak in fetch_from_offline()



commit 01518a8283cd67063f8d53f3ba07e23599594088
Author: David Woodhouse <David Woodhouse intel com>
Date:   Mon Jun 10 23:43:41 2013 +0100

    Remove bogus comment and fix leak in fetch_from_offline()
    
    e_data_book_view_notify_updte_prefiltered_vcard() does *not* steal the
    vcard it's given. It sanifies it to ensure it's valid UTF-8, allocating
    a new copy in the process.

 src/addressbook/e-book-backend-ews.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
---
diff --git a/src/addressbook/e-book-backend-ews.c b/src/addressbook/e-book-backend-ews.c
index beba6e9..af9bf3b 100644
--- a/src/addressbook/e-book-backend-ews.c
+++ b/src/addressbook/e-book-backend-ews.c
@@ -3209,9 +3209,7 @@ fetch_from_offline (EBookBackendEws *ews,
        for (l = contacts; l != NULL; l = g_slist_next (l)) {
                EbSdbSearchData *s_data = (EbSdbSearchData *) l->data;
 
-               /* reset vcard to NULL as it would be free'ed in prefiltered_vcard function */
                e_data_book_view_notify_update_prefiltered_vcard (book_view, s_data->uid, s_data->vcard);
-               s_data->vcard = NULL;
 
                e_book_backend_sqlitedb_search_data_free (s_data);
        }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]