[gegl] Warn about duplicate operation names
- From: Daniel Sabo <daniels src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gegl] Warn about duplicate operation names
- Date: Wed, 5 Jun 2013 04:15:25 +0000 (UTC)
commit f548300ff04babda0a9b36a07b34e7d474908fd4
Author: Daniel Sabo <DanielSabo gmail com>
Date: Tue Jun 4 21:02:22 2013 -0700
Warn about duplicate operation names
gegl/operation/gegl-operations.c | 17 +++++++++++++++++
1 files changed, 17 insertions(+), 0 deletions(-)
---
diff --git a/gegl/operation/gegl-operations.c b/gegl/operation/gegl-operations.c
index 64a61b3..6880db7 100644
--- a/gegl/operation/gegl-operations.c
+++ b/gegl/operation/gegl-operations.c
@@ -42,6 +42,7 @@ add_operations (GHashTable *hash,
GType parent)
{
GType *types;
+ GType check_type;
guint count;
guint no;
@@ -54,10 +55,26 @@ add_operations (GHashTable *hash,
GeglOperationClass *operation_class = g_type_class_ref (types[no]);
if (operation_class->name)
{
+ check_type = (GType)g_hash_table_lookup (hash, operation_class->name);
+ if (check_type && check_type != types[no])
+ {
+ g_warning ("Adding %s shadows %s for operation %s",
+ g_type_name (types[no]),
+ g_type_name ((GType)check_type),
+ operation_class->name);
+ }
g_hash_table_insert (hash, g_strdup (operation_class->name), (gpointer) types[no]);
}
if (operation_class->compat_name)
{
+ check_type = (GType)g_hash_table_lookup (hash, operation_class->name);
+ if (check_type && check_type != types[no])
+ {
+ g_warning ("Adding %s shadows %s for operation %s",
+ g_type_name (types[no]),
+ g_type_name ((GType)check_type),
+ operation_class->compat_name);
+ }
g_hash_table_insert (hash, g_strdup (operation_class->compat_name), (gpointer) types[no]);
}
add_operations (hash, types[no]);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]