[gnumeric] Do not show placeholders in function tooltip. [#705049]



commit 09a5683b9ca82ee962e77c1dfde739ed5256401d
Author: Andreas J Guelzow <aguelzow pyrshep ca>
Date:   Mon Jul 29 12:34:35 2013 -0600

    Do not show placeholders in function tooltip. [#705049]
    
    2013-07-29  Andreas J. Guelzow <aguelzow pyrshep ca>
    
        * src/func.c (gnm_func_lookup_prefix): do not include placeholders

 ChangeLog  |    4 ++++
 NEWS       |    1 +
 src/func.c |   10 ++++++----
 3 files changed, 11 insertions(+), 4 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index df7b6f5..2176de4 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2013-07-29  Andreas J. Guelzow <aguelzow pyrshep ca>
+
+       * src/func.c (gnm_func_lookup_prefix): do not include placeholders
+
 2013-07-25  Andreas J. Guelzow <aguelzow pyrshep ca>
        for Dmitry Smirnov
        * gnumeric.desktop.in: add ODS files
diff --git a/NEWS b/NEWS
index e023091..909d86a 100644
--- a/NEWS
+++ b/NEWS
@@ -12,6 +12,7 @@ Andreas:
        * Fix crash on corrupted files. [#704636] [#705032] [#705031]
        * Fix ODF import of charts with series consisting of multiple ranges. [#704742]
        * Fix ODF export of charts with series consisting of multiple ranges.
+       * Do not show placeholders in function tooltip. [#705049]
 
 Jean:
        * Fix text wrap inside sheet objects. [#704417]
diff --git a/src/func.c b/src/func.c
index 2121360..a518df2 100644
--- a/src/func.c
+++ b/src/func.c
@@ -1123,10 +1123,12 @@ gnm_func_lookup_prefix (char const *prefix, Workbook *scope, gboolean trans)
        g_hash_table_iter_init (&hiter, functions_by_name);
        while (g_hash_table_iter_next (&hiter, NULL, &value)) {
                GnmFunc *fd = value;
-               const char *name = gnm_func_get_name (fd, trans);
-               if (g_str_has_prefix (name, prefix)) {
-                       gnm_func_ref (fd);
-                       res = g_slist_prepend (res, fd);
+               if (!(fd->flags & GNM_FUNC_IS_PLACEHOLDER)) {
+                       const char *name = gnm_func_get_name (fd, trans);
+                       if (g_str_has_prefix (name, prefix)) {
+                               gnm_func_ref (fd);
+                               res = g_slist_prepend (res, fd);
+                       }
                }
        }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]