[gnumeric] xlsx: plug leak.



commit 602446a914ddab818511169f346d502bcdc0b405
Author: Morten Welinder <terra gnome org>
Date:   Fri Jul 26 10:19:30 2013 -0400

    xlsx: plug leak.
    
    A malformed document can cause us to stop parsing without calling
    the cell-end handler.

 NEWS                      |    1 +
 plugins/excel/ChangeLog   |    4 ++++
 plugins/excel/xlsx-read.c |    1 +
 3 files changed, 6 insertions(+), 0 deletions(-)
---
diff --git a/NEWS b/NEWS
index dae0284..0098c03 100644
--- a/NEWS
+++ b/NEWS
@@ -21,6 +21,7 @@ Morten:
        * Fix crashes on corrupted files.  [#704102] [#704004] [#704325]
        [#704562]
        * Fix conditional format problem.  [#704445]
+       * Plug leak.  [#704820]
 
 --------------------------------------------------------------------------
 Gnumeric 1.12.4
diff --git a/plugins/excel/ChangeLog b/plugins/excel/ChangeLog
index 14c481d..b433f19 100644
--- a/plugins/excel/ChangeLog
+++ b/plugins/excel/ChangeLog
@@ -1,3 +1,7 @@
+2013-07-26  Morten Welinder  <terra gnome org>
+
+       * xlsx-read.c (xlsx_file_open): Release state.val, just in case.
+
 2013-07-21  Andreas J. Guelzow <aguelzow pyrshep ca>
 
        * xlsx-write-pivot.c (xlsx_write_pivot_val): check for NULL
diff --git a/plugins/excel/xlsx-read.c b/plugins/excel/xlsx-read.c
index 7959d13..3080b38 100644
--- a/plugins/excel/xlsx-read.c
+++ b/plugins/excel/xlsx-read.c
@@ -4844,6 +4844,7 @@ xlsx_file_open (G_GNUC_UNUSED GOFileOpener const *fo, GOIOContext *context,
        xlsx_style_array_free (state.dxfs);
        xlsx_style_array_free (state.table_styles);
        g_hash_table_destroy (state.theme_colors_by_name);
+       value_release (state.val);
 
        workbook_set_saveinfo (state.wb, GO_FILE_FL_AUTO,
                               go_file_saver_for_id ((state.version == ECMA_376_2006) ?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]