[gnumeric] Fix multiple selection in graph series.



commit 4c21c90a9fdcb6786cb9f88353223b1b9fcdfc4e
Author: Jean Brefort <jean brefort normalesup org>
Date:   Tue Jul 23 20:55:07 2013 +0200

    Fix multiple selection in graph series.

 ChangeLog   |    5 +++++
 src/graph.c |    8 ++++----
 2 files changed, 9 insertions(+), 4 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 4b160ef..f982ecc 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2013-07-23  Jean Brefort  <jean brefort normalesup org>
+
+       * src/graph.c (gnm_go_data_vector_load_values): really load all values for
+       multiple ranges.
+
 2013-07-19  Morten Welinder  <terra gnome org>
 
        * src/style-conditions.c (gnm_style_cond_is_valid): Even stricter
diff --git a/src/graph.c b/src/graph.c
index 771785e..7f60f0c 100644
--- a/src/graph.c
+++ b/src/graph.c
@@ -618,8 +618,8 @@ struct assign_closure {
        double minimum, maximum;
        double *vals;
        gssize vals_len;
-       unsigned last;
-       unsigned i;
+       guint64 last;
+       guint64 i;
 };
 
 static GnmValue *
@@ -723,7 +723,7 @@ gnm_go_data_vector_load_values (GODataVector *dat)
                break;
 
        case VALUE_ARRAY : {
-               int last = 0;
+               guint64 last = 0, max = dat->len;
                int len = vec->val->v_array.y * vec->val->v_array.x;
                int x = 0, y = vec->val->v_array.y;
                GnmValue *v;
@@ -753,7 +753,7 @@ gnm_go_data_vector_load_values (GODataVector *dat)
                                        closure.maximum = - G_MAXDOUBLE;
                                        closure.minimum = G_MAXDOUBLE;
                                        closure.vals = dat->values;
-                                       closure.vals_len = dat->len;
+                                       closure.vals_len = max;
                                        closure.last = last - 1;
                                        closure.i = last;
                                        sheet_foreach_cell_in_range (start_sheet, CELL_ITER_IGNORE_FILTERED,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]