[gnumeric] Conditional formats: don't insist on sheet in references.



commit 98992b029e47c7aa44535c160463cdf8718e0b49
Author: Morten Welinder <terra gnome org>
Date:   Sun Jul 21 16:50:01 2013 -0400

    Conditional formats: don't insist on sheet in references.
    
    This way, we can have a reference like "B2" which refers to current
    sheet even after a sheet duplication.

 NEWS                                  |    1 +
 src/dialogs/ChangeLog                 |    5 +++++
 src/dialogs/dialog-cell-format-cond.c |    2 ++
 3 files changed, 8 insertions(+), 0 deletions(-)
---
diff --git a/NEWS b/NEWS
index d8e7459..dc1c4f7 100644
--- a/NEWS
+++ b/NEWS
@@ -18,6 +18,7 @@ Morten:
        * Fix crazy parsing problem.  [#704109] [#704140]
        * Fix crashes on corrupted files.  [#704102] [#704004] [#704325]
        [#704562]
+       * Fix conditional format problem.  [#704445]
 
 --------------------------------------------------------------------------
 Gnumeric 1.12.4
diff --git a/src/dialogs/ChangeLog b/src/dialogs/ChangeLog
index fa87c36..8e56e73 100644
--- a/src/dialogs/ChangeLog
+++ b/src/dialogs/ChangeLog
@@ -1,3 +1,8 @@
+2013-07-21  Morten Welinder  <terra gnome org>
+
+       * dialog-cell-format-cond.c (c_fmt_dialog_init_editor_page): Don't
+       force references to have sheet.  Fixes #704445.
+
 2013-07-10  Morten Welinder <terra gnome org>
 
        * Release 1.12.4
diff --git a/src/dialogs/dialog-cell-format-cond.c b/src/dialogs/dialog-cell-format-cond.c
index 41b7074..660417b 100644
--- a/src/dialogs/dialog-cell-format-cond.c
+++ b/src/dialogs/dialog-cell-format-cond.c
@@ -1160,6 +1160,7 @@ c_fmt_dialog_init_editor_page (CFormatState *state)
        gtk_widget_set_hexpand (state->editor.expr_x, TRUE);
        gtk_widget_show(state->editor.expr_x);
        gnm_expr_entry_set_flags (GNM_EXPR_ENTRY (state->editor.expr_x),
+                                 GNM_EE_SHEET_OPTIONAL |
                                  GNM_EE_CONSTANT_ALLOWED,
                                  GNM_EE_MASK);
 
@@ -1168,6 +1169,7 @@ c_fmt_dialog_init_editor_page (CFormatState *state)
        gtk_widget_set_hexpand (state->editor.expr_y, TRUE);
        gtk_widget_show(state->editor.expr_y);
        gnm_expr_entry_set_flags (GNM_EXPR_ENTRY (state->editor.expr_y),
+                                 GNM_EE_SHEET_OPTIONAL |
                                  GNM_EE_CONSTANT_ALLOWED,
                                  GNM_EE_MASK);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]