[gnome-shell/wip/aggregate-menu: 14/48] network: Remove the firmware changed signal



commit 24b3f90d774f7b10174114f8957cf4a873d6eeed
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Tue Jul 16 18:59:00 2013 -0400

    network: Remove the firmware changed signal
    
    According to Dan Williams, if firmware is installed the device
    will disappear and reappear, and this is unlikely to change any
    time soon. Just make our lives easier by removing the tracking.

 js/ui/status/network.js |   15 ---------------
 1 files changed, 0 insertions(+), 15 deletions(-)
---
diff --git a/js/ui/status/network.js b/js/ui/status/network.js
index feafb43..5788a4e 100644
--- a/js/ui/status/network.js
+++ b/js/ui/status/network.js
@@ -306,10 +306,6 @@ const NMDevice = new Lang.Class({
                 GObject.Object.prototype.disconnect.call(this._device, this._activeConnectionChangedId);
                 this._stateChangedId = 0;
             }
-            if (this._firmwareChangedId) {
-                GObject.Object.prototype.disconnect.call(this._device, this._firmwareChangedId);
-                this._firmwareChangedId = 0;
-            }
 
             this._device = null;
         }
@@ -375,14 +371,6 @@ const NMDevice = new Lang.Class({
         // in the majority of cases (wired, wwan)
     },
 
-    _firmwareChanged: function() {
-        if (this._firmwareChangedId) {
-            GObject.Object.prototype.disconnect.call(this._device, this._firmwareChangedId);
-            this._firmwareChangedId = 0;
-        }
-        this._substateChanged();
-    },
-
     getStatusLabel: function() {
         if (!this._device)
             return null;
@@ -411,9 +399,6 @@ const NMDevice = new Lang.Class({
             // firmware missing), that are exposed by different properties (whose state may
             // or may not updated when we receive state-changed).
             if (this._device.firmware_missing) {
-                if (!this._firmwareChangedId)
-                    this._firmwareChangedId = this._device.connect('notify::firmware-missing', 
Lang.bind(this, this._firmwareChanged));
-
                 /* Translators: this is for devices that require some kind of firmware or kernel
                    module, which is missing */
                 return _("firmware missing");


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]