[gnumeric] HLINK: Check record length.



commit 358308ed439fabb667c0a495afc91bbdd660f325
Author: Morten Welinder <terra gnome org>
Date:   Tue Jul 9 15:58:14 2013 -0400

    HLINK: Check record length.

 plugins/excel/ms-excel-read.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/plugins/excel/ms-excel-read.c b/plugins/excel/ms-excel-read.c
index ab8c4f0..a0b15ae 100644
--- a/plugins/excel/ms-excel-read.c
+++ b/plugins/excel/ms-excel-read.c
@@ -5828,8 +5828,8 @@ excel_read_HLINK (BiffQuery *q, ExcelReadSheet *esheet)
            next_opcode == BIFF_LINK_TIP) {
                ms_biff_query_next (q);
                /* according to OO the bytes 2..10 are the range for the tip */
-               if (q->data != NULL)
-                       tip = read_utf16_str ((q->length - 10)/ 2, q->data + 10);
+               XL_CHECK_CONDITION (q->length > 10);
+               tip = read_utf16_str ((q->length - 10)/ 2, q->data + 10);
        }
 
        if (link != NULL) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]