[evolution-data-server] EDataBook: Remove unused "handle-cancel-all" signal handler.



commit 7235b4ca6f0c0b42b2fec4769a4e756ed81990f5
Author: Matthew Barnes <mbarnes redhat com>
Date:   Tue Jan 29 08:55:16 2013 -0500

    EDataBook: Remove unused "handle-cancel-all" signal handler.
    
    EBookClient never invokes this method directly.  Operations are
    explicitly cancelled when EBookClient invokes the close() method.

 addressbook/libedata-book/e-data-book.c |   23 -----------------------
 1 files changed, 0 insertions(+), 23 deletions(-)
---
diff --git a/addressbook/libedata-book/e-data-book.c b/addressbook/libedata-book/e-data-book.c
index 149f16e..d5a99f0 100644
--- a/addressbook/libedata-book/e-data-book.c
+++ b/addressbook/libedata-book/e-data-book.c
@@ -75,7 +75,6 @@ typedef enum {
 	OP_MODIFY_CONTACTS,
 	OP_GET_BACKEND_PROPERTY,
 	OP_GET_VIEW,
-	OP_CANCEL_ALL,
 	OP_CLOSE
 } OperationID;
 
@@ -107,7 +106,6 @@ typedef struct {
 		gchar *prop_name;
 
 		/* OP_REFRESH */
-		/* OP_CANCEL_ALL */
 		/* OP_CLOSE */
 	} d;
 } OperationData;
@@ -390,7 +388,6 @@ operation_thread (gpointer data,
 		/* close just cancels all pending ops and frees data book */
 		e_book_backend_remove_client (backend, op->book);
 
-	case OP_CANCEL_ALL:
 		g_rec_mutex_lock (&op->book->priv->pending_ops_lock);
 
 		g_hash_table_iter_init (&iter, op->book->priv->pending_ops);
@@ -839,23 +836,6 @@ data_book_handle_get_view_cb (EGdbusBook *interface,
 }
 
 static gboolean
-data_book_handle_cancel_all_cb (EGdbusBook *interface,
-                                GDBusMethodInvocation *invocation,
-                                EDataBook *book)
-{
-	OperationData *op;
-
-	op = op_new (OP_CANCEL_ALL, book, invocation);
-
-	e_gdbus_book_complete_cancel_all (interface, invocation, NULL);
-
-	/* This operation is never queued. */
-	e_operation_pool_push (ops_pool, op);
-
-	return TRUE;
-}
-
-static gboolean
 data_book_handle_close_cb (EGdbusBook *interface,
                            GDBusMethodInvocation *invocation,
                            EDataBook *book)
@@ -1551,9 +1531,6 @@ e_data_book_init (EDataBook *ebook)
 		dbus_interface, "handle-get-view",
 		G_CALLBACK (data_book_handle_get_view_cb), ebook);
 	g_signal_connect (
-		dbus_interface, "handle-cancel-all",
-		G_CALLBACK (data_book_handle_cancel_all_cb), ebook);
-	g_signal_connect (
 		dbus_interface, "handle-close",
 		G_CALLBACK (data_book_handle_close_cb), ebook);
 }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]