[pitivi] effects: Scale down thumbnails to fit better in the new listview arrangement
- From: Jean-FranÃois Fortin Tam <jfft src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [pitivi] effects: Scale down thumbnails to fit better in the new listview arrangement
- Date: Fri, 25 Jan 2013 20:38:29 +0000 (UTC)
commit 2f2c92a48025afe7caaee54d07d1dccd0a836d16
Author: Jean-FranÃois Fortin Tam <nekohayo gmail com>
Date: Fri Jan 25 14:47:35 2013 -0500
effects: Scale down thumbnails to fit better in the new listview arrangement
pitivi/effects.py | 15 +++++++++------
1 files changed, 9 insertions(+), 6 deletions(-)
---
diff --git a/pitivi/effects.py b/pitivi/effects.py
index b509eb6..d9d8dde 100644
--- a/pitivi/effects.py
+++ b/pitivi/effects.py
@@ -68,6 +68,7 @@ BLACKLISTED_EFFECTS = ["colorconvert", "coglogoinsert", "festival",
#FIXME Check if this is still true with GES
#We should unblacklist it when #650985 is solved
BLACKLISTED_PLUGINS = ["ldaspa"]
+ICON_WIDTH = 48 + 2 * 6 # 48 pixels, plus a margin on each side
class Effect():
@@ -333,13 +334,15 @@ class EffectsHandler(object):
effect_name = effect_name + ".png"
icon = None
try:
- icon = GdkPixbuf.Pixbuf.new_from_file(os.path.join(self._pixdir, effect_name))
- # empty except clause is bad but load_icon raises Gio.Error.
- ## Right, *gio*.
+ # We can afford to scale the images here, the impact is negligible
+ icon = GdkPixbuf.Pixbuf.new_from_file_at_size(
+ os.path.join(self._pixdir, effect_name),
+ ICON_WIDTH, ICON_WIDTH)
+ # An empty except clause is bad, but "gi._glib.GError" is not helpful.
except:
try:
- icon = GdkPixbuf.Pixbuf.new_from_file(os.path.join(self._pixdir,
- "defaultthumbnail.svg"))
+ icon = GdkPixbuf.Pixbuf.new_from_file(
+ os.path.join(self._pixdir, "defaultthumbnail.svg"))
except:
return None
@@ -397,7 +400,7 @@ class EffectListWidget(Gtk.VBox, Loggable):
icon_col = Gtk.TreeViewColumn()
icon_col.props.spacing = SPACING
icon_col.set_sizing(Gtk.TreeViewColumnSizing.FIXED)
- icon_col.props.fixed_width = 96
+ icon_col.props.fixed_width = ICON_WIDTH
icon_cell = Gtk.CellRendererPixbuf()
icon_cell.props.xpad = 6
icon_col.pack_start(icon_cell, True)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]