[evolution-data-server] Fixed regression in e_book_get_book_view_async().
- From: Tristan Van Berkom <tvb src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution-data-server] Fixed regression in e_book_get_book_view_async().
- Date: Wed, 23 Jan 2013 11:45:34 +0000 (UTC)
commit 56f8302cc5165e624a5a0d0d7dbf2de07cda4c8d
Author: Tristan Van Berkom <tristanvb openismus com>
Date: Wed Jan 23 14:34:54 2013 +0900
Fixed regression in e_book_get_book_view_async().
The reference counting scheme on the returned view was changed while
porting the EBook apis to use EBookClient apis internally, the result
is that the async callback no longer receives ownership of the passed
EBookView (this commit reverts to the old behaviour).
addressbook/libebook/e-book.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
---
diff --git a/addressbook/libebook/e-book.c b/addressbook/libebook/e-book.c
index 28c9bbe..3f7af4a 100644
--- a/addressbook/libebook/e-book.c
+++ b/addressbook/libebook/e-book.c
@@ -1647,9 +1647,6 @@ get_book_view_reply (GObject *source_object,
if (excb != NULL)
excb (data->book, error, view, data->closure);
- if (view != NULL)
- g_object_unref (view);
-
if (error != NULL)
g_error_free (error);
@@ -1663,7 +1660,7 @@ get_book_view_reply (GObject *source_object,
* @query: an #EBookQuery
* @requested_fields: (element-type utf8): a #GList containing the names of fields to return, or NULL for all
* @max_results: the maximum number of contacts to show (or 0 for all)
- * @cb: (scope call): a function to call when the operation finishes
+ * @cb: (scope async): a function to call when the operation finishes
* @closure: data to pass to callback function
*
* Query @book with @query, creating a #EBookView with the fields
@@ -1710,7 +1707,7 @@ e_book_async_get_book_view (EBook *book,
* @requested_fields: (allow-none) (element-type utf8): a #GList containing the names of fields to
* return, or NULL for all
* @max_results: the maximum number of contacts to show (or 0 for all)
- * @cb: (scope call): a function to call when the operation finishes
+ * @cb: (scope async): a function to call when the operation finishes
* @closure: data to pass to callback function
*
* Query @book with @query, creating a #EBookView with the fields
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]