[evolution-data-server] CamelIMAPXStore: Pass a GError to get_folder_offline().



commit ef83c8ec426c681122ba3e3868379b3073d26b48
Author: Matthew Barnes <mbarnes redhat com>
Date:   Tue Jan 22 10:12:38 2013 -0500

    CamelIMAPXStore: Pass a GError to get_folder_offline().
    
    This is just silly.  get_folder_offline() already sets the GError on
    failure.  There's no reason for imapx_store_get_folder_sync() to not
    pass the GError to get_folder_offline() and then set its own generic
    error message on failure.

 camel/camel-imapx-store.c |   13 +------------
 1 files changed, 1 insertions(+), 12 deletions(-)
---
diff --git a/camel/camel-imapx-store.c b/camel/camel-imapx-store.c
index de98c66..9181331 100644
--- a/camel/camel-imapx-store.c
+++ b/camel/camel-imapx-store.c
@@ -1258,18 +1258,7 @@ imapx_store_get_folder_sync (CamelStore *store,
                              GCancellable *cancellable,
                              GError **error)
 {
-	CamelFolder *folder;
-
-	folder = get_folder_offline (store, folder_name, flags, NULL);
-	if (folder == NULL) {
-		g_set_error (
-			error, CAMEL_STORE_ERROR,
-			CAMEL_STORE_ERROR_NO_FOLDER,
-			_("No such folder: %s"), folder_name);
-		return NULL;
-	}
-
-	return folder;
+	return get_folder_offline (store, folder_name, flags, error);
 }
 
 static CamelFolderInfo *



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]