[cogl/wip/cogl-1.14: 88/177] texture: split out high-level texture constructors



commit 2adfe6d80577e12f817c85026fb699b2859b82ec
Author: Robert Bragg <robert linux intel com>
Date:   Thu Nov 8 20:33:00 2012 +0000

    texture: split out high-level texture constructors
    
    This splits out the very high level texture constructors that may
    internally construct one of several types of lower level texture due to
    various constraints.
    
    This also updates the prototypes for these constructors to take an
    explicit context pointer and return a CoglError consistent with other
    texture constructors.
    
    Reviewed-by: Neil Roberts <neil linux intel com>
    
    (cherry picked from commit a1cabfae6ad50c51006c608cdde7d631b7832e71)

 cogl/Makefile.am                      |    1 +
 cogl/cogl-atlas-texture.c             |    9 +
 cogl/cogl-atlas.c                     |   16 +-
 cogl/cogl-atlas.h                     |   14 +-
 cogl/cogl-auto-texture.c              |  343 +++++++++++++++++++++++++++++++++
 cogl/cogl-texture-2d-sliced-private.h |   16 +-
 cogl/cogl-texture-2d-sliced.c         |   34 ++--
 cogl/cogl-texture-private.h           |    4 +
 cogl/cogl-texture.c                   |  299 +----------------------------
 9 files changed, 400 insertions(+), 336 deletions(-)
---
diff --git a/cogl/Makefile.am b/cogl/Makefile.am
index 9a75eb7..e53392c 100644
--- a/cogl/Makefile.am
+++ b/cogl/Makefile.am
@@ -361,6 +361,7 @@ cogl_sources_c = \
 	$(srcdir)/cogl-texture-driver.h			\
 	$(srcdir)/cogl-sub-texture.c                    \
 	$(srcdir)/cogl-texture.c			\
+	$(srcdir)/cogl-auto-texture.c			\
 	$(srcdir)/cogl-texture-2d.c                     \
 	$(srcdir)/cogl-texture-2d-sliced.c		\
 	$(srcdir)/cogl-texture-3d.c                     \
diff --git a/cogl/cogl-atlas-texture.c b/cogl/cogl-atlas-texture.c
index 5489c7b..99ca746 100644
--- a/cogl/cogl-atlas-texture.c
+++ b/cogl/cogl-atlas-texture.c
@@ -388,6 +388,15 @@ _cogl_atlas_texture_migrate_out_of_atlas (CoglAtlasTexture *atlas_tex)
                                     atlas_tex->rectangle.height - 2,
                                     COGL_TEXTURE_NO_ATLAS,
                                     atlas_tex->format);
+      /* Note: we simply silently ignore failures to migrate a texture
+       * out (most likely due to lack of memory) and hope for the
+       * best.
+       *
+       * Maybe we should find a way to report the problem back to the
+       * app.
+       */
+      if (!standalone_tex)
+        return;
 
       /* Notify cogl-pipeline.c that the texture's underlying GL texture
        * storage is changing so it knows it may need to bind a new texture
diff --git a/cogl/cogl-atlas.c b/cogl/cogl-atlas.c
index 855fb50..62b11f8 100644
--- a/cogl/cogl-atlas.c
+++ b/cogl/cogl-atlas.c
@@ -537,17 +537,19 @@ _cogl_atlas_remove (CoglAtlas *atlas,
 };
 
 CoglTexture *
-_cogl_atlas_copy_rectangle (CoglAtlas        *atlas,
-                            unsigned int      x,
-                            unsigned int      y,
-                            unsigned int      width,
-                            unsigned int      height,
-                            CoglTextureFlags  flags,
-                            CoglPixelFormat   format)
+_cogl_atlas_copy_rectangle (CoglAtlas *atlas,
+                            int x,
+                            int y,
+                            int width,
+                            int height,
+                            CoglTextureFlags flags,
+                            CoglPixelFormat format)
 {
   CoglTexture *tex;
   CoglBlitData blit_data;
 
+  _COGL_GET_CONTEXT (ctx, NULL);
+
   /* Create a new texture at the right size */
   tex = cogl_texture_new_with_size (width, height, flags, format);
 
diff --git a/cogl/cogl-atlas.h b/cogl/cogl-atlas.h
index 02fac4a..85e0aab 100644
--- a/cogl/cogl-atlas.h
+++ b/cogl/cogl-atlas.h
@@ -75,13 +75,13 @@ _cogl_atlas_remove (CoglAtlas *atlas,
                     const CoglRectangleMapEntry *rectangle);
 
 CoglTexture *
-_cogl_atlas_copy_rectangle (CoglAtlas        *atlas,
-                            unsigned int      x,
-                            unsigned int      y,
-                            unsigned int      width,
-                            unsigned int      height,
-                            CoglTextureFlags  flags,
-                            CoglPixelFormat   format);
+_cogl_atlas_copy_rectangle (CoglAtlas *atlas,
+                            int x,
+                            int y,
+                            int width,
+                            int height,
+                            CoglTextureFlags flags,
+                            CoglPixelFormat format);
 
 void
 _cogl_atlas_add_reorganize_callback (CoglAtlas            *atlas,
diff --git a/cogl/cogl-auto-texture.c b/cogl/cogl-auto-texture.c
new file mode 100644
index 0000000..bcb3386
--- /dev/null
+++ b/cogl/cogl-auto-texture.c
@@ -0,0 +1,343 @@
+/*
+ * Cogl
+ *
+ * An object oriented GL/GLES Abstraction/Utility Layer
+ *
+ * Copyright (C) 2007,2008,2009,2011,2012 Intel Corporation.
+ * Copyright (C) 2010 Red Hat, Inc.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library. If not, see <http://www.gnu.org/licenses/>.
+ *
+ *
+ *
+ * Authors:
+ *  Matthew Allum  <mallum openedhand com>
+ *  Neil Roberts   <neil linux intel com>
+ *  Robert Bragg   <robert linux intel com>
+ */
+
+#ifdef HAVE_CONFIG_H
+#include "config.h"
+#endif
+
+#include "cogl-context-private.h"
+#include "cogl-texture.h"
+#include "cogl-util.h"
+#include "cogl-texture-2d.h"
+#include "cogl-primitive-texture.h"
+#include "cogl-texture-2d-sliced-private.h"
+#include "cogl-private.h"
+#include "cogl-object.h"
+#include "cogl-bitmap-private.h"
+#include "cogl-atlas-texture-private.h"
+#include "cogl-error-private.h"
+#include "cogl-texture-rectangle.h"
+#include "cogl-sub-texture.h"
+#include "cogl-texture-2d-gl.h"
+
+CoglTexture *
+cogl_texture_new_with_size (unsigned int     width,
+			    unsigned int     height,
+                            CoglTextureFlags flags,
+			    CoglPixelFormat  internal_format)
+{
+  CoglTexture *tex;
+
+  _COGL_GET_CONTEXT (ctx, NULL);
+
+  if ((_cogl_util_is_pot (width) && _cogl_util_is_pot (height)) ||
+      (cogl_has_feature (ctx, COGL_FEATURE_ID_TEXTURE_NPOT_BASIC) &&
+       cogl_has_feature (ctx, COGL_FEATURE_ID_TEXTURE_NPOT_MIPMAP)))
+    {
+      /* First try creating a fast-path non-sliced texture */
+      tex = COGL_TEXTURE (cogl_texture_2d_new_with_size (ctx,
+                                                         width, height,
+                                                         internal_format,
+                                                         NULL));
+    }
+  else
+    tex = NULL;
+
+  if (tex)
+    {
+      CoglBool auto_mipmap = !(flags & COGL_TEXTURE_NO_AUTO_MIPMAP);
+      cogl_primitive_texture_set_auto_mipmap (COGL_PRIMITIVE_TEXTURE (tex),
+                                              auto_mipmap);
+    }
+  else
+    {
+      /* If it fails resort to sliced textures */
+      int max_waste = flags & COGL_TEXTURE_NO_SLICING ? -1 : COGL_TEXTURE_MAX_WASTE;
+      tex = COGL_TEXTURE (cogl_texture_2d_sliced_new_with_size (ctx,
+                                                                width,
+                                                                height,
+                                                                max_waste,
+                                                                internal_format,
+                                                                NULL));
+    }
+
+  return tex;
+}
+
+static CoglTexture *
+_cogl_texture_new_from_data (CoglContext *ctx,
+                             int width,
+                             int height,
+                             CoglTextureFlags flags,
+                             CoglPixelFormat format,
+                             CoglPixelFormat internal_format,
+                             int rowstride,
+                             const uint8_t *data,
+                             CoglError **error)
+{
+  CoglBitmap *bmp;
+  CoglTexture *tex;
+
+  _COGL_RETURN_VAL_IF_FAIL (format != COGL_PIXEL_FORMAT_ANY, NULL);
+  _COGL_RETURN_VAL_IF_FAIL (data != NULL, NULL);
+
+  /* Rowstride from width if not given */
+  if (rowstride == 0)
+    rowstride = width * _cogl_pixel_format_get_bytes_per_pixel (format);
+
+  /* Wrap the data into a bitmap */
+  bmp = cogl_bitmap_new_for_data (ctx,
+                                  width, height,
+                                  format,
+                                  rowstride,
+                                  (uint8_t *) data);
+
+  tex = _cogl_texture_new_from_bitmap (bmp, flags, internal_format, error);
+
+  cogl_object_unref (bmp);
+
+  return tex;
+}
+
+CoglTexture *
+cogl_texture_new_from_data (int width,
+                            int height,
+                            CoglTextureFlags flags,
+                            CoglPixelFormat format,
+                            CoglPixelFormat internal_format,
+                            int rowstride,
+                            const uint8_t *data)
+{
+  CoglError *ignore_error = NULL;
+  CoglTexture *tex;
+
+  _COGL_GET_CONTEXT (ctx, NULL);
+
+  tex = _cogl_texture_new_from_data (ctx,
+                                     width, height,
+                                     flags,
+                                     format, internal_format,
+                                     rowstride,
+                                     data,
+                                     &ignore_error);
+  if (!tex)
+    cogl_error_free (ignore_error);
+  return tex;
+}
+
+CoglTexture *
+_cogl_texture_new_from_bitmap (CoglBitmap *bitmap,
+                               CoglTextureFlags flags,
+                               CoglPixelFormat internal_format,
+                               CoglError **error)
+{
+  CoglContext *ctx = _cogl_bitmap_get_context (bitmap);
+  CoglAtlasTexture *atlas_tex;
+  CoglTexture *tex;
+  CoglError *internal_error = NULL;
+
+  /* First try putting the texture in the atlas */
+  if ((atlas_tex = _cogl_atlas_texture_new_from_bitmap (bitmap,
+                                                        flags,
+                                                        internal_format,
+                                                        &internal_error)))
+    return COGL_TEXTURE (atlas_tex);
+
+  if (cogl_error_matches (internal_error,
+                          COGL_SYSTEM_ERROR,
+                          COGL_SYSTEM_ERROR_NO_MEMORY))
+    {
+      _cogl_propogate_error (error, internal_error);
+      return NULL;
+    }
+
+  cogl_error_free (internal_error);
+  internal_error = NULL;
+
+  /* If that doesn't work try a fast path 2D texture */
+  if ((_cogl_util_is_pot (bitmap->width) &&
+       _cogl_util_is_pot (bitmap->height)) ||
+      (cogl_has_feature (ctx, COGL_FEATURE_ID_TEXTURE_NPOT_BASIC) &&
+       cogl_has_feature (ctx, COGL_FEATURE_ID_TEXTURE_NPOT_MIPMAP)))
+    {
+      tex = COGL_TEXTURE (cogl_texture_2d_new_from_bitmap (bitmap,
+                                                           internal_format,
+                                                           &internal_error));
+
+      if (cogl_error_matches (internal_error,
+                              COGL_SYSTEM_ERROR,
+                              COGL_SYSTEM_ERROR_NO_MEMORY))
+        {
+          _cogl_propogate_error (error, internal_error);
+          return NULL;
+        }
+
+      if (!tex)
+        {
+          cogl_error_free (internal_error);
+          internal_error = NULL;
+        }
+    }
+  else
+    tex = NULL;
+
+  if (tex)
+    {
+      CoglBool auto_mipmap = !(flags & COGL_TEXTURE_NO_AUTO_MIPMAP);
+      cogl_primitive_texture_set_auto_mipmap (COGL_PRIMITIVE_TEXTURE (tex),
+                                              auto_mipmap);
+    }
+  else
+    {
+      /* Otherwise create a sliced texture */
+      tex = COGL_TEXTURE (_cogl_texture_2d_sliced_new_from_bitmap (bitmap,
+                                                             flags,
+                                                             internal_format,
+                                                             error));
+    }
+
+  return tex;
+}
+
+CoglTexture *
+cogl_texture_new_from_bitmap (CoglBitmap *bitmap,
+                              CoglTextureFlags flags,
+                              CoglPixelFormat internal_format)
+{
+  CoglError *ignore_error = NULL;
+  CoglTexture *tex =
+    _cogl_texture_new_from_bitmap (bitmap, flags, internal_format,
+                                   &ignore_error);
+  if (!tex)
+    cogl_error_free (ignore_error);
+  return tex;
+}
+
+CoglTexture *
+cogl_texture_new_from_file (const char        *filename,
+                            CoglTextureFlags   flags,
+                            CoglPixelFormat    internal_format,
+                            CoglError           **error)
+{
+  CoglBitmap *bmp;
+  CoglTexture *texture = NULL;
+  CoglPixelFormat src_format;
+
+  _COGL_GET_CONTEXT (ctx, NULL);
+
+  _COGL_RETURN_VAL_IF_FAIL (error == NULL || *error == NULL, NULL);
+
+  bmp = cogl_bitmap_new_from_file (filename, error);
+  if (bmp == NULL)
+    return NULL;
+
+  src_format = cogl_bitmap_get_format (bmp);
+
+  /* We know that the bitmap data is solely owned by this function so
+     we can do the premult conversion in place. This avoids having to
+     copy the bitmap which will otherwise happen in
+     _cogl_texture_prepare_for_upload */
+  internal_format =
+    _cogl_texture_determine_internal_format (src_format, internal_format);
+  if (!_cogl_texture_needs_premult_conversion (src_format, internal_format) ||
+      _cogl_bitmap_convert_premult_status (bmp,
+                                           src_format ^ COGL_PREMULT_BIT,
+                                           error))
+    {
+      texture =
+        _cogl_texture_new_from_bitmap (bmp, flags, internal_format, error);
+    }
+
+  cogl_object_unref (bmp);
+
+  return texture;
+}
+
+CoglTexture *
+cogl_texture_new_from_foreign (GLuint           gl_handle,
+			       GLenum           gl_target,
+			       GLuint           width,
+			       GLuint           height,
+			       GLuint           x_pot_waste,
+			       GLuint           y_pot_waste,
+			       CoglPixelFormat  format)
+{
+  _COGL_GET_CONTEXT (ctx, NULL);
+
+#if HAVE_COGL_GL
+  if (gl_target == GL_TEXTURE_RECTANGLE_ARB)
+    {
+      CoglTextureRectangle *texture_rectangle;
+      CoglSubTexture *sub_texture;
+
+      if (x_pot_waste != 0 || y_pot_waste != 0)
+        {
+          /* It shouldn't be necessary to have waste in this case since
+           * the texture isn't limited to power of two sizes. */
+          g_warning ("You can't create a foreign GL_TEXTURE_RECTANGLE cogl "
+                     "texture with waste\n");
+          return NULL;
+        }
+
+      texture_rectangle = cogl_texture_rectangle_new_from_foreign (ctx,
+                                                                   gl_handle,
+                                                                   width,
+                                                                   height,
+                                                                   format,
+                                                                   NULL);
+
+      /* CoglTextureRectangle textures work with non-normalized
+       * coordinates, but the semantics for this function that people
+       * depend on are that all returned texture works with normalized
+       * coordinates so we wrap with a CoglSubTexture... */
+      sub_texture = cogl_sub_texture_new (ctx,
+                                          COGL_TEXTURE (texture_rectangle),
+                                          0, 0, width, height);
+      return COGL_TEXTURE (sub_texture);
+    }
+#endif
+
+  if (x_pot_waste != 0 || y_pot_waste != 0)
+    return COGL_TEXTURE (_cogl_texture_2d_sliced_new_from_foreign (ctx,
+                                                                   gl_handle,
+                                                                   gl_target,
+                                                                   width,
+                                                                   height,
+                                                                   x_pot_waste,
+                                                                   y_pot_waste,
+                                                                   format,
+                                                                   NULL));
+  else
+    return COGL_TEXTURE (cogl_texture_2d_new_from_foreign (ctx,
+                                                           gl_handle,
+                                                           width,
+                                                           height,
+                                                           format,
+                                                           NULL));
+}
diff --git a/cogl/cogl-texture-2d-sliced-private.h b/cogl/cogl-texture-2d-sliced-private.h
index 760db98..9a43bdf 100644
--- a/cogl/cogl-texture-2d-sliced-private.h
+++ b/cogl/cogl-texture-2d-sliced-private.h
@@ -44,13 +44,15 @@ struct _CoglTexture2DSliced
 };
 
 CoglTexture2DSliced *
-_cogl_texture_2d_sliced_new_from_foreign (GLuint           gl_handle,
-                                          GLenum           gl_target,
-                                          GLuint           width,
-                                          GLuint           height,
-                                          GLuint           x_pot_waste,
-                                          GLuint           y_pot_waste,
-                                          CoglPixelFormat  format);
+_cogl_texture_2d_sliced_new_from_foreign (CoglContext *context,
+                                          unsigned int gl_handle,
+                                          unsigned int gl_target,
+                                          int width,
+                                          int height,
+                                          int x_pot_waste,
+                                          int y_pot_waste,
+                                          CoglPixelFormat  format,
+                                          CoglError **error);
 
 CoglTexture2DSliced *
 _cogl_texture_2d_sliced_new_from_bitmap (CoglBitmap *bmp,
diff --git a/cogl/cogl-texture-2d-sliced.c b/cogl/cogl-texture-2d-sliced.c
index 4b3c481..e79f07b 100644
--- a/cogl/cogl-texture-2d-sliced.c
+++ b/cogl/cogl-texture-2d-sliced.c
@@ -992,32 +992,32 @@ _cogl_texture_2d_sliced_new_from_bitmap (CoglBitmap *bmp,
 }
 
 CoglTexture2DSliced *
-_cogl_texture_2d_sliced_new_from_foreign (GLuint           gl_handle,
-                                          GLenum           gl_target,
-                                          GLuint           width,
-                                          GLuint           height,
-                                          GLuint           x_pot_waste,
-                                          GLuint           y_pot_waste,
-                                          CoglPixelFormat  format)
+_cogl_texture_2d_sliced_new_from_foreign (CoglContext *ctx,
+                                          unsigned int gl_handle,
+                                          unsigned int gl_target,
+                                          int width,
+                                          int height,
+                                          int x_pot_waste,
+                                          int y_pot_waste,
+                                          CoglPixelFormat format,
+                                          CoglError **error)
 {
   /* NOTE: width, height and internal format are not queriable
    * in GLES, hence such a function prototype.
    */
 
-  GLint                gl_width = 0;
-  GLint                gl_height = 0;
+  int gl_width = 0;
+  int gl_height = 0;
   CoglTexture2DSliced *tex_2ds;
-  CoglTexture         *tex;
-  CoglSpan             x_span;
-  CoglSpan             y_span;
-  CoglTexture2D       *tex_2d;
-
-  _COGL_GET_CONTEXT (ctx, NULL);
+  CoglTexture *tex;
+  CoglSpan x_span;
+  CoglSpan y_span;
+  CoglTexture2D *tex_2d;
 
   /* This should only be called when the texture target is 2D. If a
      rectangle texture is used then _cogl_texture_new_from_foreign
      will create a cogl_texture_rectangle instead */
-  g_assert (gl_target == GL_TEXTURE_2D);
+  _COGL_RETURN_VAL_IF_FAIL (gl_target == GL_TEXTURE_2D, NULL);
 
   gl_width = width + x_pot_waste;
   gl_height = height + y_pot_waste;
@@ -1032,7 +1032,7 @@ _cogl_texture_2d_sliced_new_from_foreign (GLuint           gl_handle,
                                              gl_width,
                                              gl_height,
                                              format,
-                                             NULL);
+                                             error);
 
   if (!tex_2d)
     return NULL;
diff --git a/cogl/cogl-texture-private.h b/cogl/cogl-texture-private.h
index 51fdf0b..c862ecd 100644
--- a/cogl/cogl-texture-private.h
+++ b/cogl/cogl-texture-private.h
@@ -312,4 +312,8 @@ _cogl_texture_set_region_from_bitmap (CoglTexture *texture,
                                       CoglBitmap *bmp,
                                       CoglError **error);
 
+CoglBool
+_cogl_texture_needs_premult_conversion (CoglPixelFormat src_format,
+                                        CoglPixelFormat dst_format);
+
 #endif /* __COGL_TEXTURE_PRIVATE_H */
diff --git a/cogl/cogl-texture.c b/cogl/cogl-texture.c
index 9e52524..25426c3 100644
--- a/cogl/cogl-texture.c
+++ b/cogl/cogl-texture.c
@@ -144,7 +144,7 @@ _cogl_texture_free (CoglTexture *texture)
   g_free (texture);
 }
 
-static CoglBool
+CoglBool
 _cogl_texture_needs_premult_conversion (CoglPixelFormat src_format,
                                         CoglPixelFormat dst_format)
 {
@@ -312,303 +312,6 @@ _cogl_texture_prep_gl_alignment_for_pixels_download (int bpp,
   GE( ctx, glPixelStorei (GL_PACK_ALIGNMENT, alignment) );
 }
 
-CoglTexture *
-cogl_texture_new_with_size (unsigned int     width,
-			    unsigned int     height,
-                            CoglTextureFlags flags,
-			    CoglPixelFormat  internal_format)
-{
-  CoglTexture *tex;
-
-  _COGL_GET_CONTEXT (ctx, NULL);
-
-  if ((_cogl_util_is_pot (width) && _cogl_util_is_pot (height)) ||
-      (cogl_has_feature (ctx, COGL_FEATURE_ID_TEXTURE_NPOT_BASIC) &&
-       cogl_has_feature (ctx, COGL_FEATURE_ID_TEXTURE_NPOT_MIPMAP)))
-    {
-      /* First try creating a fast-path non-sliced texture */
-      tex = COGL_TEXTURE (cogl_texture_2d_new_with_size (ctx,
-                                                         width, height,
-                                                         internal_format,
-                                                         NULL));
-    }
-  else
-    tex = NULL;
-
-  if (tex)
-    {
-      CoglBool auto_mipmap = !(flags & COGL_TEXTURE_NO_AUTO_MIPMAP);
-      cogl_primitive_texture_set_auto_mipmap (COGL_PRIMITIVE_TEXTURE (tex),
-                                              auto_mipmap);
-    }
-  else
-    {
-      /* If it fails resort to sliced textures */
-      int max_waste = flags & COGL_TEXTURE_NO_SLICING ? -1 : COGL_TEXTURE_MAX_WASTE;
-      tex = COGL_TEXTURE (cogl_texture_2d_sliced_new_with_size (ctx,
-                                                                width,
-                                                                height,
-                                                                max_waste,
-                                                                internal_format,
-                                                                NULL));
-    }
-
-  return tex;
-}
-
-static CoglTexture *
-_cogl_texture_new_from_data (CoglContext *ctx,
-                             int width,
-                             int height,
-                             CoglTextureFlags flags,
-                             CoglPixelFormat format,
-                             CoglPixelFormat internal_format,
-                             int rowstride,
-                             const uint8_t *data,
-                             CoglError **error)
-{
-  CoglBitmap *bmp;
-  CoglTexture *tex;
-
-  _COGL_RETURN_VAL_IF_FAIL (format != COGL_PIXEL_FORMAT_ANY, NULL);
-  _COGL_RETURN_VAL_IF_FAIL (data != NULL, NULL);
-
-  /* Rowstride from width if not given */
-  if (rowstride == 0)
-    rowstride = width * _cogl_pixel_format_get_bytes_per_pixel (format);
-
-  /* Wrap the data into a bitmap */
-  bmp = cogl_bitmap_new_for_data (ctx,
-                                  width, height,
-                                  format,
-                                  rowstride,
-                                  (uint8_t *) data);
-
-  tex = _cogl_texture_new_from_bitmap (bmp, flags, internal_format, error);
-
-  cogl_object_unref (bmp);
-
-  return tex;
-}
-
-CoglTexture *
-cogl_texture_new_from_data (int width,
-                            int height,
-                            CoglTextureFlags flags,
-                            CoglPixelFormat format,
-                            CoglPixelFormat internal_format,
-                            int rowstride,
-                            const uint8_t *data)
-{
-  CoglError *ignore_error = NULL;
-  CoglTexture *tex;
-
-  _COGL_GET_CONTEXT (ctx, NULL);
-
-  tex = _cogl_texture_new_from_data (ctx,
-                                     width, height,
-                                     flags,
-                                     format, internal_format,
-                                     rowstride,
-                                     data,
-                                     &ignore_error);
-  if (!tex)
-    cogl_error_free (ignore_error);
-  return tex;
-}
-
-CoglTexture *
-_cogl_texture_new_from_bitmap (CoglBitmap *bitmap,
-                               CoglTextureFlags flags,
-                               CoglPixelFormat internal_format,
-                               CoglError **error)
-{
-  CoglContext *ctx = _cogl_bitmap_get_context (bitmap);
-  CoglAtlasTexture *atlas_tex;
-  CoglTexture *tex;
-  CoglError *internal_error = NULL;
-
-  /* First try putting the texture in the atlas */
-  if ((atlas_tex = _cogl_atlas_texture_new_from_bitmap (bitmap,
-                                                        flags,
-                                                        internal_format,
-                                                        &internal_error)))
-    return COGL_TEXTURE (atlas_tex);
-
-  if (cogl_error_matches (internal_error,
-                          COGL_SYSTEM_ERROR,
-                          COGL_SYSTEM_ERROR_NO_MEMORY))
-    {
-      _cogl_propogate_error (error, internal_error);
-      return NULL;
-    }
-
-  cogl_error_free (internal_error);
-  internal_error = NULL;
-
-  /* If that doesn't work try a fast path 2D texture */
-  if ((_cogl_util_is_pot (bitmap->width) &&
-       _cogl_util_is_pot (bitmap->height)) ||
-      (cogl_has_feature (ctx, COGL_FEATURE_ID_TEXTURE_NPOT_BASIC) &&
-       cogl_has_feature (ctx, COGL_FEATURE_ID_TEXTURE_NPOT_MIPMAP)))
-    {
-      tex = COGL_TEXTURE (cogl_texture_2d_new_from_bitmap (bitmap,
-                                                           internal_format,
-                                                           &internal_error));
-
-      if (cogl_error_matches (internal_error,
-                              COGL_SYSTEM_ERROR,
-                              COGL_SYSTEM_ERROR_NO_MEMORY))
-        {
-          _cogl_propogate_error (error, internal_error);
-          return NULL;
-        }
-
-      if (!tex)
-        {
-          cogl_error_free (internal_error);
-          internal_error = NULL;
-        }
-    }
-  else
-    tex = NULL;
-
-  if (tex)
-    {
-      CoglBool auto_mipmap = !(flags & COGL_TEXTURE_NO_AUTO_MIPMAP);
-      cogl_primitive_texture_set_auto_mipmap (COGL_PRIMITIVE_TEXTURE (tex),
-                                              auto_mipmap);
-    }
-  else
-    {
-      /* Otherwise create a sliced texture */
-      tex = COGL_TEXTURE (_cogl_texture_2d_sliced_new_from_bitmap (bitmap,
-                                                             flags,
-                                                             internal_format,
-                                                             error));
-    }
-
-  return tex;
-}
-
-CoglTexture *
-cogl_texture_new_from_bitmap (CoglBitmap *bitmap,
-                              CoglTextureFlags flags,
-                              CoglPixelFormat internal_format)
-{
-  CoglError *ignore_error = NULL;
-  CoglTexture *tex =
-    _cogl_texture_new_from_bitmap (bitmap, flags, internal_format,
-                                   &ignore_error);
-  if (!tex)
-    cogl_error_free (ignore_error);
-  return tex;
-}
-
-CoglTexture *
-cogl_texture_new_from_file (const char        *filename,
-                            CoglTextureFlags   flags,
-                            CoglPixelFormat    internal_format,
-                            CoglError           **error)
-{
-  CoglBitmap *bmp;
-  CoglTexture *texture = NULL;
-  CoglPixelFormat src_format;
-
-  _COGL_GET_CONTEXT (ctx, NULL);
-
-  _COGL_RETURN_VAL_IF_FAIL (error == NULL || *error == NULL, NULL);
-
-  bmp = cogl_bitmap_new_from_file (filename, error);
-  if (bmp == NULL)
-    return NULL;
-
-  src_format = cogl_bitmap_get_format (bmp);
-
-  /* We know that the bitmap data is solely owned by this function so
-     we can do the premult conversion in place. This avoids having to
-     copy the bitmap which will otherwise happen in
-     _cogl_texture_prepare_for_upload */
-  internal_format =
-    _cogl_texture_determine_internal_format (src_format, internal_format);
-  if (!_cogl_texture_needs_premult_conversion (src_format, internal_format) ||
-      _cogl_bitmap_convert_premult_status (bmp,
-                                           src_format ^ COGL_PREMULT_BIT,
-                                           error))
-    {
-      texture =
-        _cogl_texture_new_from_bitmap (bmp, flags, internal_format, error);
-    }
-
-  cogl_object_unref (bmp);
-
-  return texture;
-}
-
-CoglTexture *
-cogl_texture_new_from_foreign (GLuint           gl_handle,
-			       GLenum           gl_target,
-			       GLuint           width,
-			       GLuint           height,
-			       GLuint           x_pot_waste,
-			       GLuint           y_pot_waste,
-			       CoglPixelFormat  format)
-{
-#if HAVE_COGL_GL
-  if (gl_target == GL_TEXTURE_RECTANGLE_ARB)
-    {
-      CoglTextureRectangle *texture_rectangle;
-      CoglSubTexture *sub_texture;
-
-      _COGL_GET_CONTEXT (ctx, NULL);
-
-      if (x_pot_waste != 0 || y_pot_waste != 0)
-        {
-          /* It shouldn't be necessary to have waste in this case since
-           * the texture isn't limited to power of two sizes. */
-          g_warning ("You can't create a foreign GL_TEXTURE_RECTANGLE cogl "
-                     "texture with waste\n");
-          return NULL;
-        }
-
-      texture_rectangle = cogl_texture_rectangle_new_from_foreign (ctx,
-                                                                   gl_handle,
-                                                                   width,
-                                                                   height,
-                                                                   format,
-                                                                   NULL);
-
-      /* CoglTextureRectangle textures work with non-normalized
-       * coordinates, but the semantics for this function that people
-       * depend on are that all returned texture works with normalized
-       * coordinates so we wrap with a CoglSubTexture... */
-      sub_texture = cogl_sub_texture_new (ctx,
-                                          COGL_TEXTURE (texture_rectangle),
-                                          0, 0, width, height);
-      return COGL_TEXTURE (sub_texture);
-    }
-#endif
-
-  if (x_pot_waste != 0 || y_pot_waste != 0)
-    return COGL_TEXTURE (_cogl_texture_2d_sliced_new_from_foreign (gl_handle,
-                                                                   gl_target,
-                                                                   width,
-                                                                   height,
-                                                                   x_pot_waste,
-                                                                   y_pot_waste,
-                                                                   format));
-  else
-    {
-      _COGL_GET_CONTEXT (ctx, NULL);
-      return COGL_TEXTURE (cogl_texture_2d_new_from_foreign (ctx,
-                                                             gl_handle,
-                                                             width,
-                                                             height,
-                                                             format,
-                                                             NULL));
-    }
-}
-
 CoglBool
 _cogl_texture_is_foreign (CoglTexture *texture)
 {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]