[gjs] object: Force signal detail quark creation on signal connections
- From: Rui Matos <rtcm src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gjs] object: Force signal detail quark creation on signal connections
- Date: Mon, 14 Jan 2013 15:30:13 +0000 (UTC)
commit 19784d70393d4ef23c8e07d06ea052b003ea2dc4
Author: Rui Matos <tiagomatos gmail com>
Date: Mon Jan 14 16:07:07 2013 +0100
object: Force signal detail quark creation on signal connections
Otherwise handlers for detailed signals will always get called even
when the detail doesn't match the emited one.
This used to work before because g_signal_connect_closure() forces the
detail quark creation implicitly, but since we switched to
g_signal_connect_closure_by_id(), this is the right thing to do.
https://bugzilla.gnome.org/show_bug.cgi?id=691719
gi/object.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/gi/object.c b/gi/object.c
index a5aac2e..bfb3a3c 100644
--- a/gi/object.c
+++ b/gi/object.c
@@ -1182,7 +1182,7 @@ real_connect_func(JSContext *context,
G_OBJECT_TYPE(priv->gobj),
&signal_id,
&signal_detail,
- FALSE)) {
+ TRUE)) {
gjs_throw(context, "No signal '%s' on object '%s'",
signal_name,
g_type_name(G_OBJECT_TYPE(priv->gobj)));
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]