[easytag] Fix some more set-but-unused warnings

[David King <davidk src gnome org>]

commit cd7bf25e8236f61e3f17fc685c407b460b80b94a
Author: Andreas Winkelmann <ml awinkelmann de>
Date:   Sat Jan 12 07:54:50 2013 +0000

    Fix some more set-but-unused warnings

 src/cddb.c       |    3 +--
 src/easytag.c    |   13 ++++++++-----
 src/ogg_header.c |    5 -----
 src/ogg_tag.c    |    3 +--
 4 files changed, 10 insertions(+), 14 deletions(-)
---
diff --git a/src/cddb.c b/src/cddb.c
index 904201e..7e86c47 100644
--- a/src/cddb.c
+++ b/src/cddb.c
@@ -2703,7 +2703,7 @@ gboolean Cddb_Search_Album_List_From_String_Gnudb (void)
             && strstr(cddb_out_tmp,end_str) != NULL )
             {
                 gchar *ptr_art_alb, *ptr_end;
-                gchar *copy, *valid;
+                gchar *valid;
                 CddbAlbum *cddbalbum;
 
                 cddbalbum = g_malloc0(sizeof(CddbAlbum));
@@ -2761,7 +2761,6 @@ gboolean Cddb_Search_Album_List_From_String_Gnudb (void)
                 strncpy(buffer,cddb_out_tmp,MAX_STRING_LEN);
                 if ( (ptr_end=strstr(buffer,end_str)) != NULL )
                     *ptr_end = 0;
-                copy = g_strdup(buffer);
                 cddbalbum->artist_album = Try_To_Validate_Utf8_String(buffer);
 
                 CddbAlbumList = g_list_append(CddbAlbumList,cddbalbum);
diff --git a/src/easytag.c b/src/easytag.c
index 0ffe1d7..c3a9bea 100644
--- a/src/easytag.c
+++ b/src/easytag.c
@@ -180,7 +180,6 @@ int main (int argc, char *argv[])
 {
     GtkWidget *MainVBox;
     GtkWidget *HBox, *VBox;
-    gboolean created_settings;
     struct stat statbuf;
     //GError *error = NULL;
     GdkPixbuf *pixbuf;
@@ -233,8 +232,12 @@ int main (int argc, char *argv[])
                 get_locale(),get_encoding_from_locale(get_locale()));
 
 
-    /* Create all config files */
-    created_settings = Setting_Create_Files();
+    /* Create all config files. */
+    if (!Setting_Create_Files())
+    {
+        Log_Print (LOG_WARNING, _("Unable to create setting directories"));
+    }
+
     /* Load Config */
     Init_Config_Variables();
     Read_Config();
@@ -3307,10 +3310,10 @@ gint Delete_File (ET_File *ETFile, gboolean multiple_files)
 
     if (!ETFile) return FALSE;
 
-    // Filename of the file to delete
+    /* Filename of the file to delete. */
     cur_filename      = ((File_Name *)(ETFile->FileNameCur)->data)->value;
     cur_filename_utf8 = ((File_Name *)(ETFile->FileNameCur)->data)->value_utf8;
-    basename_utf8 = g_path_get_basename(cur_filename);
+    basename_utf8 = g_path_get_basename (cur_filename_utf8);
 
     /*
      * Remove the file
diff --git a/src/ogg_header.c b/src/ogg_header.c
index 27d23d3..f9e26da 100644
--- a/src/ogg_header.c
+++ b/src/ogg_header.c
@@ -64,9 +64,7 @@ gboolean Ogg_Header_Read_File_Info (gchar *filename, ET_File_Info *ETFileInfo)
     gint encoder_version = 0;
     gint channels = 0;
     glong rate = 0;
-    glong bitrate_upper = 0;
     glong bitrate_nominal = 0;
-    glong bitrate_lower = 0;
     gdouble duration = 0;
     gulong filesize;
     gint ret;
@@ -91,10 +89,7 @@ gboolean Ogg_Header_Read_File_Info (gchar *filename, ET_File_Info *ETFileInfo)
             encoder_version = vi->version;         // Vorbis encoder version used to create this bitstream.
             channels        = vi->channels;        // Number of channels in bitstream.
             rate            = vi->rate;            // (Hz) Sampling rate of the bitstream.
-            bitrate_upper   = vi->bitrate_upper;   // (b/s) Specifies the upper limit in a VBR bitstream.
             bitrate_nominal = vi->bitrate_nominal; // (b/s) Specifies the average bitrate for a VBR bitstream.
-            //bitrate_nominal = ov_bitrate(&vf,-1);  // (b/s) Specifies the average bitrate for the specified logical bitstream.
-            bitrate_lower   = vi->bitrate_nominal; // (b/s) Specifies the lower limit in a VBR bitstream.
         }else
         {
             Log_Print(LOG_ERROR,_("Ogg Vorbis: The specified bitstream does not exist or the "
diff --git a/src/ogg_tag.c b/src/ogg_tag.c
index 305152d..2f1f3b4 100644
--- a/src/ogg_tag.c
+++ b/src/ogg_tag.c
@@ -800,7 +800,6 @@ gboolean Ogg_Tag_Write_File_Tag (ET_File *ETFile)
         if (pic->data)
         {
             gchar *data_encoded = NULL;
-            gint size;
             Picture_Format format = Picture_Format_From_Data(pic);
 
             string = g_strdup_printf("COVERARTMIME=%s",Picture_Mime_Type_String(format));
@@ -821,7 +820,7 @@ gboolean Ogg_Tag_Write_File_Tag (ET_File *ETFile)
                 g_free(string);
             }
 
-            size = base64_encode(pic->data, pic->size, &data_encoded);
+            base64_encode (pic->data, pic->size, &data_encoded);
             string = g_strdup_printf("COVERART=%s",data_encoded);
             vorbis_comment_add(vc,string);
             g_free(data_encoded);