[glom] MySQL: Some fixes
- From: Murray Cumming <murrayc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glom] MySQL: Some fixes
- Date: Fri, 11 Jan 2013 15:34:58 +0000 (UTC)
commit 5dc2fa6b29463f6174de7a9c8a5a6ec0da669c4d
Author: Murray Cumming <murrayc murrayc com>
Date: Fri Jan 4 00:24:54 2013 +0100
MySQL: Some fixes
glom/libglom/connectionpool_backends/mysql.cc | 5 +----
glom/libglom/connectionpool_backends/mysql_self.cc | 1 -
tests/test_selfhosting_new_empty_then_users.cc | 15 ++++++++++++++-
3 files changed, 15 insertions(+), 6 deletions(-)
---
diff --git a/glom/libglom/connectionpool_backends/mysql.cc b/glom/libglom/connectionpool_backends/mysql.cc
index a21ce50..50c2e60 100644
--- a/glom/libglom/connectionpool_backends/mysql.cc
+++ b/glom/libglom/connectionpool_backends/mysql.cc
@@ -857,10 +857,7 @@ bool MySQL::supports_remote_access() const
Gnome::Gda::SqlOperatorType MySQL::get_string_find_operator() const
{
- //TODO_MySQL:
- // ILIKE is a MySQL extension for locale-dependent case-insensitive matches.
- //See http://developer.mysqlql.org/pgdocs/mysql/functions-matching.html
- return Gnome::Gda::SQL_OPERATOR_TYPE_ILIKE;
+ return Gnome::Gda::SQL_OPERATOR_TYPE_LIKE;
}
const char* MySQL::get_public_schema_name() const
diff --git a/glom/libglom/connectionpool_backends/mysql_self.cc b/glom/libglom/connectionpool_backends/mysql_self.cc
index 6ce6b64..dfd47e4 100644
--- a/glom/libglom/connectionpool_backends/mysql_self.cc
+++ b/glom/libglom/connectionpool_backends/mysql_self.cc
@@ -363,7 +363,6 @@ Backend::StartupErrors MySQLSelfHosted::startup(const SlotProgress& slot_progres
//std::cout << G_STRFUNC << ": debug: command_check_mysql_has_started=" << command_check_mysql_has_started << std::endl;
const bool result = Glom::Spawn::execute_command_line_and_wait_until_second_command_returns_success(command_mysql_start, command_check_mysql_has_started, slot_progress, second_command_success_text);
- std::cout << G_STRFUNC << std::cout << " DEBUG: started" << std::endl;
if(!result)
{
diff --git a/tests/test_selfhosting_new_empty_then_users.cc b/tests/test_selfhosting_new_empty_then_users.cc
index 5bb5c82..545a261 100644
--- a/tests/test_selfhosting_new_empty_then_users.cc
+++ b/tests/test_selfhosting_new_empty_then_users.cc
@@ -138,7 +138,12 @@ static bool test(Glom::Document::HostingMode hosting_mode)
table_names.push_back("sometable with space characters");
table_names.push_back("sometable with a \" doublequote character");
table_names.push_back("sometable with a ' quote character");
- table_names.push_back("sometablewithaverylongnameyaddayaddayaddayaddayaddyaddayaddayaddayaddayaddayaddayaddayaddayaddayaddayaddayadda");
+
+ //MySQL has a 64-character limit on SQL identifiers:
+ if(hosting_mode != Glom::Document::HOSTING_MODE_MYSQL_SELF)
+ {
+ table_names.push_back("sometablewithaverylongnameyaddayaddayaddayaddayaddyaddayaddayaddayaddayaddayaddayaddayaddayaddayaddayaddayadda");
+ }
//Add some tables, for the groups to have rights for:
for(type_vec_strings::const_iterator iter = table_names.begin(); iter != table_names.end(); ++iter)
@@ -151,6 +156,14 @@ static bool test(Glom::Document::HostingMode hosting_mode)
}
+ //TODO_MySQL: Implement groups/users code.
+ if(hosting_mode == Glom::Document::HOSTING_MODE_MYSQL_SELF)
+ {
+ test_selfhosting_cleanup(false /* do not delete the file. */);
+ return true;
+ }
+
+
//Check that only one group exists (the developer group):
const Glom::Privs::type_vec_strings group_list_original = Glom::Privs::get_database_groups();
if(group_list_original.empty())
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]