[gtk+/gtk-3-6] Don't check the same crossing mode twice



commit 5d551918805f0c938bce36c912c9b41c3af6e1a6
Author: Matthias Clasen <mclasen redhat com>
Date:   Thu Nov 29 22:06:18 2012 -0500

    Don't check the same crossing mode twice
    
    This was broken since commit b2aaa94 in 2008. Its commit message
    clearly states that the intention was to check for GTK_GRAB,
    GTK_UNGRAB and STATE_CHANGED. Lets do that, then.
    
    This was found by Coverity.

 gtk/gtkmenushell.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/gtk/gtkmenushell.c b/gtk/gtkmenushell.c
index bc4f5f7..81fe3a8 100644
--- a/gtk/gtkmenushell.c
+++ b/gtk/gtkmenushell.c
@@ -1107,7 +1107,7 @@ gtk_menu_shell_leave_notify (GtkWidget        *widget,
                              GdkEventCrossing *event)
 {
   if (event->mode == GDK_CROSSING_GTK_GRAB ||
-      event->mode == GDK_CROSSING_GTK_GRAB ||
+      event->mode == GDK_CROSSING_GTK_UNGRAB ||
       event->mode == GDK_CROSSING_STATE_CHANGED)
     return TRUE;
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]