[goffice] Regression: fix the fix.



commit 5858bff7f8b1c2cc4306888ce3f47571ed9b8ab7
Author: Morten Welinder <terra gnome org>
Date:   Thu Feb 21 11:49:39 2013 -0500

    Regression: fix the fix.

 ChangeLog                    |    6 ++++++
 goffice/math/go-regression.c |    2 --
 2 files changed, 6 insertions(+), 2 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 8b7b776..1d641f2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2013-02-21  Morten Welinder  <terra gnome org>
+
+       * goffice/math/go-regression.c (general_linear_regression): Drop
+       the memset.  The constructor does it and with ref-counting it
+       doesn't work.
+
 2013-02-20  Jean Brefort  <jean brefort normalesup org>
 
        * goffice/component/go-component.c (go_component_build_snapshot): always
diff --git a/goffice/math/go-regression.c b/goffice/math/go-regression.c
index 75c4af5..ebaf0d9 100644
--- a/goffice/math/go-regression.c
+++ b/goffice/math/go-regression.c
@@ -884,8 +884,6 @@ SUFFIX(general_linear_regression) (CONSTMATRIX xssT, int n,
        if (!has_stat)
                stat_ = SUFFIX(go_regression_stat_new)();
 
-       memset (stat_, 0, sizeof (*stat_));
-
        if (n > m) {
                regerr = GO_REG_not_enough_data;
                goto out;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]