[gnome-shell] shellEntry: Don't navigate forward before popping up the menu
- From: Jasper St. Pierre <jstpierre src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] shellEntry: Don't navigate forward before popping up the menu
- Date: Mon, 18 Feb 2013 21:34:27 +0000 (UTC)
commit 75589b44504ddd449d4b142ff8f858cfa0bab70c
Author: Jasper St. Pierre <jstpierre mecheye net>
Date: Mon Feb 18 16:06:53 2013 -0500
shellEntry: Don't navigate forward before popping up the menu
Doing it before the grab messes up the grab helper's tracking
of where the focus was before, leading to it not tracking the
saved focus correctly, meaning that when we pop the menu back
down with escape, it doesn't restore focus correctly.
https://bugzilla.gnome.org/show_bug.cgi?id=694123
js/ui/shellEntry.js | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/js/ui/shellEntry.js b/js/ui/shellEntry.js
index 5ca730c..b71c809 100644
--- a/js/ui/shellEntry.js
+++ b/js/ui/shellEntry.js
@@ -74,12 +74,12 @@ const EntryMenu = new Lang.Class({
if (this._passwordItem)
this._updatePasswordItem();
+ this.parent(animate);
+ this._entry.add_style_pseudo_class('focus');
+
let direction = Gtk.DirectionType.TAB_FORWARD;
if (!this.actor.navigate_focus(null, direction, false))
this.actor.grab_key_focus();
-
- this.parent(animate);
- this._entry.add_style_pseudo_class('focus');
},
close: function(animate) {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]