[gnome-documents] selections: set correct visibility to toolbar items



commit 02e61e4062e5cda8838f6d57c1199e5141f01e4f
Author: Cosimo Cecchi <cosimoc gnome org>
Date:   Sat Feb 16 10:17:44 2013 -0500

    selections: set correct visibility to toolbar items
    
    Call show_all() on the toolbar before setItemVisibility is called, and
    then only use show/hide when fading, so to never modify the tool item's
    visibility.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=693954

 src/selections.js |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
---
diff --git a/src/selections.js b/src/selections.js
index f61e027..127a347 100644
--- a/src/selections.js
+++ b/src/selections.js
@@ -787,6 +787,8 @@ const SelectionToolbar = new Lang.Class({
         this._rightBox.add(this._toolbarShare);
         this._toolbarShare.connect('clicked', Lang.bind(this, this._onToolbarShare));
 
+        this.widget.show_all();
+
         Application.selectionController.connect('selection-mode-changed',
             Lang.bind(this, this._onSelectionModeChanged));
         Application.selectionController.connect('selection-changed',
@@ -956,7 +958,7 @@ const SelectionToolbar = new Lang.Class({
     },
 
     _fadeIn: function() {
-        this.widget.show_all();
+        this.widget.show();
         Tweener.addTween(this.widget, { opacity: 1,
                                         time: 0.30,
                                         transition: 'easeOutQuad' });


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]