[orca] Get rid of "an odd hacky thing... somewhat drawn from Gnopernicus"(!?!)



commit 004fc276ebb92b7f30cc463ba6219a1a6a539c1e
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Thu Feb 14 16:41:59 2013 -0500

    Get rid of "an odd hacky thing... somewhat drawn from Gnopernicus"(!?!)

 src/orca/script_utilities.py |   21 ---------------------
 1 files changed, 0 insertions(+), 21 deletions(-)
---
diff --git a/src/orca/script_utilities.py b/src/orca/script_utilities.py
index aff2c56..31f06e5 100644
--- a/src/orca/script_utilities.py
+++ b/src/orca/script_utilities.py
@@ -1321,27 +1321,6 @@ class Utilities:
                         if text.getText(0, self._script.getTextEndOffset(text)):
                             activeDescendant = child
 
-        # [[[TODO: WDW - this is an odd hacky thing I've somewhat drawn
-        # from Gnopernicus.  The notion here is that we get an active
-        # descendant changed event, but that object tends to have children
-        # itself and we need to decide what to do.  Well...the idea here
-        # is that the last child (Gnopernicus chooses child(1)), tends to
-        # be the child with information.  The previous children tend to
-        # be non-text or just there for spacing or something.  You will
-        # see this in the various table demos of gtk-demo and you will
-        # also see this in the Contact Source Selector in Evolution.
-        #
-        # Just note that this is most likely not a really good solution
-        # for the general case.  That needs more thought.  But, this
-        # comment is here to remind us this is being done in poor taste
-        # and we need to eventually clean up our act.]]]
-        #
-        if not activeDescendant and obj and obj.childCount >= 0:
-            try:
-                activeDescendant = obj[-1]
-            except:
-                pass
-
         self._script.generatorCache[self.REAL_ACTIVE_DESCENDANT][obj] = \
             activeDescendant or obj
         return self._script.generatorCache[self.REAL_ACTIVE_DESCENDANT][obj]


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]