[gcab] gcab: hide the --space option, it's not necessary anymore



commit 5a975e8615ee08fb5715deb0b74402b265919a8e
Author: Marc-Andrà Lureau <marcandre lureau gmail com>
Date:   Thu Feb 14 00:22:50 2013 +0100

    gcab: hide the --space option, it's not necessary anymore
    
    Listen the interweb!!! you don't need to reserve space to add
    a signature anymore.
    
    I repeat again, you _don't_ need to reserve header space to add a
    signature anymore with a somewhat recent signtool.exe. Even if some
    old msdn documentation still says so, and plenty of pages.
    
    Although the PKCS#7 data is appended at the end of the cabinet, they
    still use the reserved data field, and move the rest of the content,
    but nevermind, it's just IO after all, right...
    
    Oh, and osslsigncode doesn't need it either.

 gcab.1.in |    3 ---
 gcab.c    |    2 +-
 2 files changed, 1 insertions(+), 4 deletions(-)
---
diff --git a/gcab.1.in b/gcab.1.in
index f4f0261..3f0e7f0 100644
--- a/gcab.1.in
+++ b/gcab.1.in
@@ -24,9 +24,6 @@ create files without pathnames
 \fB\-C, --directory DIR\fR
 change or extract to directory DIR
 .TP
-\fB\-s, --space\fR
-Reserve space in cabinet for signing (e.g. -s 6144 reserves 6K bytes)
-.TP
 \fB\-v, --verbose\fR
 verbosely list files processed
 .TP
diff --git a/gcab.c b/gcab.c
index 9fa86bf..34f2731 100644
--- a/gcab.c
+++ b/gcab.c
@@ -91,7 +91,7 @@ main (int argc, char *argv[])
         { "directory", 'C', 0, G_OPTION_ARG_FILENAME, &change, N_("Change to directory DIR"), N_("DIR") },
         { "zip", 'z', 0, G_OPTION_ARG_NONE, &compress, N_("Use zip compression"), NULL },
         { "nopath", 'n', 0, G_OPTION_ARG_NONE, &nopath, N_("Do not include path"), NULL },
-        { "space", 's', 0, G_OPTION_ARG_INT, &space, N_("Reserve space in cabinet for signing (e.g. -s 6144 
reserves 6K bytes)"), NULL },
+        { "space", 's', G_OPTION_FLAG_HIDDEN, G_OPTION_ARG_INT, &space, N_("Reserve space in cabinet for 
signing (e.g. -s 6144 reserves 6K bytes)"), NULL },
         { G_OPTION_REMAINING, '\0', 0, G_OPTION_ARG_FILENAME_ARRAY, &args, NULL, N_("FILE INPUT_FILES...") },
         { NULL }
     };


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]