GNOME.org
 

[gnome-online-accounts] Clean up the libgoabackend public headers

commit 171dcbf3d0eff45a2cec3f309d83bd584de5f685
Author: Debarshi Ray <debarshir gnome org>
Date:   Wed Feb 6 15:08:53 2013 +0100

    Clean up the libgoabackend public headers
    
    The individual providers and other internal types should never be
    exported. There is nothing useful that can be done outside the GOA
    sources with them. GoaProvider and its dependencies are the only
    things that should be exported.

 src/daemon/goadaemon.c                  |    1 +
 src/daemon/main.c                       |    2 +-
 src/goabackend/Makefile.am              |   16 +--------
 src/goabackend/goabackend.h             |    6 ---
 src/goabackend/goabackendenums-priv.h   |   54 +++++++++++++++++++++++++++++++
 src/goabackend/goabackendenums.h        |   19 -----------
 src/goabackend/goabackendtypes.h        |   43 ------------------------
 src/goabackend/goaeditablelabel.h       |    5 ++-
 src/goabackend/goaewsclient.c           |    2 +-
 src/goabackend/goaewsclient.h           |    6 +++-
 src/goabackend/goaexchangeprovider.h    |    4 ++-
 src/goabackend/goafacebookprovider.h    |    4 ++-
 src/goabackend/goaflickrprovider.h      |    4 ++-
 src/goabackend/goagoogleprovider.h      |    4 ++-
 src/goabackend/goahttpclient.c          |    2 +-
 src/goabackend/goahttpclient.h          |    6 +++-
 src/goabackend/goakerberosprovider.h    |    4 ++-
 src/goabackend/goalogging.c             |    1 +
 src/goabackend/goalogging.h             |    4 ++-
 src/goabackend/goaoauth2provider.h      |    3 +-
 src/goabackend/goaoauthprovider.h       |    2 +-
 src/goabackend/goaowncloudprovider.h    |    4 ++-
 src/goabackend/goaprovider.h            |    1 +
 src/goabackend/goatwitterprovider.h     |    4 ++-
 src/goabackend/goawindowsliveprovider.h |    4 ++-
 src/goabackend/goayahooprovider.h       |    4 ++-
 src/goaidentity/goaidentityservice.c    |    2 +
 27 files changed, 110 insertions(+), 101 deletions(-)
---
diff --git a/src/daemon/goadaemon.c b/src/daemon/goadaemon.c
index e82612e..c61e07c 100644
--- a/src/daemon/goadaemon.c
+++ b/src/daemon/goadaemon.c
@@ -29,6 +29,7 @@
 
 #include "goadaemon.h"
 #include "goabackend/goabackend.h"
+#include "goabackend/goalogging.h"
 #include "goabackend/goautils.h"
 #ifdef GOA_KERBEROS_ENABLED
 #include "goaidentity/goaidentityservice.h"
diff --git a/src/daemon/main.c b/src/daemon/main.c
index 005e155..b6415f2 100644
--- a/src/daemon/main.c
+++ b/src/daemon/main.c
@@ -28,7 +28,7 @@
 #include <signal.h>
 #include <gio/gio.h>
 
-#include <goabackend/goabackend.h>
+#include <goabackend/goalogging.h>
 
 #include "goadaemon.h"
 
diff --git a/src/goabackend/Makefile.am b/src/goabackend/Makefile.am
index 2693559..666e175 100644
--- a/src/goabackend/Makefile.am
+++ b/src/goabackend/Makefile.am
@@ -48,27 +48,13 @@ libgoa_backend_1_0_la_HEADERS =						\
 	goabackendtypes.h						\
 	goabackendenums.h						\
 	goabackendenumtypes.h						\
-	goalogging.h							\
-	goaeditablelabel.h						\
 	goaprovider.h							\
-	goaexchangeprovider.h						\
-	goagoogleprovider.h						\
-	goafacebookprovider.h						\
-	goaowncloudprovider.h						\
-	goayahooprovider.h						\
-	goatwitterprovider.h						\
-	goaflickrprovider.h						\
-	goawindowsliveprovider.h					\
 	$(NULL)
 
-if BUILD_KERBEROS
-libgoa_backend_1_0_la_HEADERS +=	goakerberosprovider.h
-endif
-
 libgoa_backend_1_0_la_SOURCES =						\
 	goabackend.h							\
 	goabackendtypes.h						\
-	goabackendenums.h						\
+	goabackendenums-priv.h						\
 	goabackendenumtypes.h		goabackendenumtypes.c		\
 	goaeditablelabel.h		goaeditablelabel.c		\
 	goaewsclient.h			goaewsclient.c			\
diff --git a/src/goabackend/goabackend.h b/src/goabackend/goabackend.h
index bae963b..fa9aff8 100644
--- a/src/goabackend/goabackend.h
+++ b/src/goabackend/goabackend.h
@@ -29,13 +29,7 @@
 
 #define __GOA_BACKEND_INSIDE_GOA_BACKEND_H__
 #include <goabackend/goabackendtypes.h>
-#include <goabackend/goalogging.h>
-#include <goabackend/goaeditablelabel.h>
 #include <goabackend/goaprovider.h>
-#include <goabackend/goagoogleprovider.h>
-#include <goabackend/goafacebookprovider.h>
-#include <goabackend/goayahooprovider.h>
-#include <goabackend/goatwitterprovider.h>
 #undef __GOA_BACKEND_INSIDE_GOA_BACKEND_H__
 
 #endif /* __GOA_BACKEND_H__ */
diff --git a/src/goabackend/goabackendenums-priv.h b/src/goabackend/goabackendenums-priv.h
new file mode 100644
index 0000000..5c8eab3
--- /dev/null
+++ b/src/goabackend/goabackendenums-priv.h
@@ -0,0 +1,54 @@
+/* -*- mode: C; c-file-style: "gnu"; indent-tabs-mode: nil; -*- */
+/*
+ * Copyright (C) 2013 Red Hat, Inc.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General
+ * Public License along with this library; if not, write to the
+ * Free Software Foundation, Inc., 59 Temple Place, Suite 330,
+ * Boston, MA 02111-1307, USA.
+ *
+ * Authors: David Zeuthen <davidz redhat com>
+ *          Debarshi Ray <debarshir gnome org>
+ */
+
+#if !defined (__GOA_BACKEND_INSIDE_GOA_BACKEND_H__) && !defined (GOA_BACKEND_COMPILATION)
+#error "Only <goabackend/goabackend.h> can be included directly."
+#endif
+
+#ifndef __GOA_BACKEND_ENUMS_PRIV_H__
+#define __GOA_BACKEND_ENUMS_PRIV_H__
+
+G_BEGIN_DECLS
+
+/**
+ * GoaLogLevel:
+ * @GOA_LOG_LEVEL_DEBUG: Debug messages.
+ * @GOA_LOG_LEVEL_INFO: Informational messages.
+ * @GOA_LOG_LEVEL_NOTICE: Messages that the administrator should take notice of.
+ * @GOA_LOG_LEVEL_WARNING: Warning messages.
+ * @GOA_LOG_LEVEL_ERROR: Error messages.
+ *
+ * Logging levels.
+ */
+typedef enum
+{
+  GOA_LOG_LEVEL_DEBUG,
+  GOA_LOG_LEVEL_INFO,
+  GOA_LOG_LEVEL_NOTICE,
+  GOA_LOG_LEVEL_WARNING,
+  GOA_LOG_LEVEL_ERROR
+} GoaLogLevel;
+
+G_END_DECLS
+
+#endif /* __GOA_BACKEND_ENUMS_PRIV_H__ */
diff --git a/src/goabackend/goabackendenums.h b/src/goabackend/goabackendenums.h
index 509a03b..b5e3b32 100644
--- a/src/goabackend/goabackendenums.h
+++ b/src/goabackend/goabackendenums.h
@@ -33,25 +33,6 @@
 G_BEGIN_DECLS
 
 /**
- * GoaLogLevel:
- * @GOA_LOG_LEVEL_DEBUG: Debug messages.
- * @GOA_LOG_LEVEL_INFO: Informational messages.
- * @GOA_LOG_LEVEL_NOTICE: Messages that the administrator should take notice of.
- * @GOA_LOG_LEVEL_WARNING: Warning messages.
- * @GOA_LOG_LEVEL_ERROR: Error messages.
- *
- * Logging levels.
- */
-typedef enum
-{
-  GOA_LOG_LEVEL_DEBUG,
-  GOA_LOG_LEVEL_INFO,
-  GOA_LOG_LEVEL_NOTICE,
-  GOA_LOG_LEVEL_WARNING,
-  GOA_LOG_LEVEL_ERROR
-} GoaLogLevel;
-
-/**
  * GoaProviderGroup:
  * @GOA_PROVIDER_GROUP_BRANDED: Providers with a well-known brand. For
  *   example, Google and Facebook.
diff --git a/src/goabackend/goabackendtypes.h b/src/goabackend/goabackendtypes.h
index 4ec013d..94a2fea 100644
--- a/src/goabackend/goabackendtypes.h
+++ b/src/goabackend/goabackendtypes.h
@@ -29,55 +29,12 @@
 
 #include <goa/goa.h>
 #include <goabackend/goabackendenums.h>
-#include <gtk/gtk.h>
 
 G_BEGIN_DECLS
 
-struct _GoaEwsClient;
-typedef struct _GoaEwsClient GoaEwsClient;
-
-struct _GoaHttpClient;
-typedef struct _GoaHttpClient GoaHttpClient;
-
 struct _GoaProvider;
 typedef struct _GoaProvider GoaProvider;
 
-struct _GoaExchangeProvider;
-typedef struct _GoaExchangeProvider GoaExchangeProvider;
-
-struct _GoaKerberosProvider;
-typedef struct _GoaKerberosProvider GoaKerberosProvider;
-
-struct _GoaOAuthProvider;
-typedef struct _GoaOAuthProvider GoaOAuthProvider;
-
-struct _GoaOAuth2Provider;
-typedef struct _GoaOAuth2Provider GoaOAuth2Provider;
-
-struct _GoaGoogleProvider;
-typedef struct _GoaGoogleProvider GoaGoogleProvider;
-
-struct _GoaFacebookProvider;
-typedef struct _GoaFacebookProvider GoaFacebookProvider;
-
-struct _GoaOwncloudProvider;
-typedef struct _GoaOwncloudProvider GoaOwncloudProvider;
-
-struct _GoaYahooProvider;
-typedef struct _GoaYahooProvider GoaYahooProvider;
-
-struct _GoaTwitterProvider;
-typedef struct _GoaTwitterProvider GoaTwitterProvider;
-
-struct _GoaFlickrProvider;
-typedef struct _GoaFlickrProvider GoaFlickrProvider;
-
-struct _GoaEditableLabel;
-typedef struct _GoaEditableLabel GoaEditableLabel;
-
-struct _GoaWindowsLiveProvider;
-typedef struct _GoaWindowsLiveProvider GoaWindowsLiveProvider;
-
 G_END_DECLS
 
 #endif /* __GOA_BACKEND_TYPES_H__ */
diff --git a/src/goabackend/goaeditablelabel.h b/src/goabackend/goaeditablelabel.h
index 210a3e0..f11be10 100644
--- a/src/goabackend/goaeditablelabel.h
+++ b/src/goabackend/goaeditablelabel.h
@@ -30,7 +30,9 @@
 #ifndef __GOA_EDITABLE_LABEL_H__
 #define __GOA_EDITABLE_LABEL_H__
 
-#include <goabackend/goabackendtypes.h>
+#include <glib.h>
+#include <glib-object.h>
+#include <gtk/gtk.h>
 
 G_BEGIN_DECLS
 
@@ -41,6 +43,7 @@ G_BEGIN_DECLS
 #define GOA_IS_EDITABLE_LABEL_CLASS(k)  (G_TYPE_CHECK_CLASS_TYPE ((k), GOA_TYPE_EDITABLE_LABEL))
 #define GOA_EDITABLE_LABEL_GET_CLASS(o) (G_TYPE_INSTANCE_GET_CLASS ((o), GOA_TYPE_EDITABLE_LABEL, GoaEditableLabelClass))
 
+typedef struct _GoaEditableLabel GoaEditableLabel;
 typedef struct _GoaEditableLabelClass GoaEditableLabelClass;
 typedef struct _GoaEditableLabelPrivate GoaEditableLabelPrivate;
 
diff --git a/src/goabackend/goaewsclient.c b/src/goabackend/goaewsclient.c
index 155a508..8571770 100644
--- a/src/goabackend/goaewsclient.c
+++ b/src/goabackend/goaewsclient.c
@@ -27,7 +27,7 @@
  */
 
 #include "config.h"
-#include <glib.h>
+
 #include <glib/gi18n-lib.h>
 
 #include <libsoup/soup.h>
diff --git a/src/goabackend/goaewsclient.h b/src/goabackend/goaewsclient.h
index 367ac74..c59a8ba 100644
--- a/src/goabackend/goaewsclient.h
+++ b/src/goabackend/goaewsclient.h
@@ -27,7 +27,9 @@
 #ifndef __GOA_EWS_CLIENT_H__
 #define __GOA_EWS_CLIENT_H__
 
-#include <goabackend/goabackendtypes.h>
+#include <gio/gio.h>
+#include <glib.h>
+#include <glib-object.h>
 
 G_BEGIN_DECLS
 
@@ -35,6 +37,8 @@ G_BEGIN_DECLS
 #define GOA_EWS_CLIENT(o)           (G_TYPE_CHECK_INSTANCE_CAST ((o), GOA_TYPE_EWS_CLIENT, GoaEwsClient))
 #define GOA_IS_EWS_CLIENT(o)        (G_TYPE_CHECK_INSTANCE_TYPE ((o), GOA_TYPE_EWS_CLIENT))
 
+typedef struct _GoaEwsClient GoaEwsClient;
+
 GType           goa_ews_client_get_type            (void) G_GNUC_CONST;
 GoaEwsClient   *goa_ews_client_new                 (void);
 void            goa_ews_client_autodiscover        (GoaEwsClient        *client,
diff --git a/src/goabackend/goaexchangeprovider.h b/src/goabackend/goaexchangeprovider.h
index 76c6911..78e27b0 100644
--- a/src/goabackend/goaexchangeprovider.h
+++ b/src/goabackend/goaexchangeprovider.h
@@ -27,7 +27,7 @@
 #ifndef __GOA_EXCHANGE_PROVIDER_H__
 #define __GOA_EXCHANGE_PROVIDER_H__
 
-#include <goabackend/goabackendtypes.h>
+#include <glib-object.h>
 
 G_BEGIN_DECLS
 
@@ -35,6 +35,8 @@ G_BEGIN_DECLS
 #define GOA_EXCHANGE_PROVIDER(o)     (G_TYPE_CHECK_INSTANCE_CAST ((o), GOA_TYPE_EXCHANGE_PROVIDER, GoaExchangeProvider))
 #define GOA_IS_EXCHANGE_PROVIDER(o)  (G_TYPE_CHECK_INSTANCE_TYPE ((o), GOA_TYPE_EXCHANGE_PROVIDER))
 
+typedef struct _GoaExchangeProvider GoaExchangeProvider;
+
 GType goa_exchange_provider_get_type (void) G_GNUC_CONST;
 
 G_END_DECLS
diff --git a/src/goabackend/goafacebookprovider.h b/src/goabackend/goafacebookprovider.h
index be9655f..db37690 100644
--- a/src/goabackend/goafacebookprovider.h
+++ b/src/goabackend/goafacebookprovider.h
@@ -27,7 +27,7 @@
 #ifndef __GOA_FACEBOOK_PROVIDER_H__
 #define __GOA_FACEBOOK_PROVIDER_H__
 
-#include <goabackend/goabackendtypes.h>
+#include <glib-object.h>
 
 G_BEGIN_DECLS
 
@@ -35,6 +35,8 @@ G_BEGIN_DECLS
 #define GOA_FACEBOOK_PROVIDER(o)     (G_TYPE_CHECK_INSTANCE_CAST ((o), GOA_TYPE_FACEBOOK_PROVIDER, GoaFacebookProvider))
 #define GOA_IS_FACEBOOK_PROVIDER(o)  (G_TYPE_CHECK_INSTANCE_TYPE ((o), GOA_TYPE_FACEBOOK_PROVIDER))
 
+typedef struct _GoaFacebookProvider GoaFacebookProvider;
+
 GType goa_facebook_provider_get_type (void) G_GNUC_CONST;
 
 G_END_DECLS
diff --git a/src/goabackend/goaflickrprovider.h b/src/goabackend/goaflickrprovider.h
index 11bd533..931e61d 100644
--- a/src/goabackend/goaflickrprovider.h
+++ b/src/goabackend/goaflickrprovider.h
@@ -27,7 +27,7 @@
 #ifndef __GOA_FLICKR_PROVIDER_H__
 #define __GOA_FLICKR_PROVIDER_H__
 
-#include <goabackend/goabackendtypes.h>
+#include <glib-object.h>
 
 G_BEGIN_DECLS
 
@@ -35,6 +35,8 @@ G_BEGIN_DECLS
 #define GOA_FLICKR_PROVIDER(o)     (G_TYPE_CHECK_INSTANCE_CAST ((o), GOA_TYPE_FLICKR_PROVIDER, GoaFlickrProvider))
 #define GOA_IS_FLICKR_PROVIDER(o)  (G_TYPE_CHECK_INSTANCE_TYPE ((o), GOA_TYPE_FLICKR_PROVIDER))
 
+typedef struct _GoaFlickrProvider GoaFlickrProvider;
+
 GType goa_flickr_provider_get_type (void) G_GNUC_CONST;
 
 G_END_DECLS
diff --git a/src/goabackend/goagoogleprovider.h b/src/goabackend/goagoogleprovider.h
index b7b07d4..8f378b4 100644
--- a/src/goabackend/goagoogleprovider.h
+++ b/src/goabackend/goagoogleprovider.h
@@ -27,7 +27,7 @@
 #ifndef __GOA_GOOGLE_PROVIDER_H__
 #define __GOA_GOOGLE_PROVIDER_H__
 
-#include <goabackend/goabackendtypes.h>
+#include <glib-object.h>
 
 G_BEGIN_DECLS
 
@@ -35,6 +35,8 @@ G_BEGIN_DECLS
 #define GOA_GOOGLE_PROVIDER(o)     (G_TYPE_CHECK_INSTANCE_CAST ((o), GOA_TYPE_GOOGLE_PROVIDER, GoaGoogleProvider))
 #define GOA_IS_GOOGLE_PROVIDER(o)  (G_TYPE_CHECK_INSTANCE_TYPE ((o), GOA_TYPE_GOOGLE_PROVIDER))
 
+typedef struct _GoaGoogleProvider GoaGoogleProvider;
+
 GType goa_google_provider_get_type (void) G_GNUC_CONST;
 
 G_END_DECLS
diff --git a/src/goabackend/goahttpclient.c b/src/goabackend/goahttpclient.c
index 828cb09..26cd493 100644
--- a/src/goabackend/goahttpclient.c
+++ b/src/goabackend/goahttpclient.c
@@ -21,7 +21,7 @@
  */
 
 #include "config.h"
-#include <glib.h>
+
 #include <glib/gi18n-lib.h>
 
 #include <libsoup/soup.h>
diff --git a/src/goabackend/goahttpclient.h b/src/goabackend/goahttpclient.h
index bad5c9b..79fbc54 100644
--- a/src/goabackend/goahttpclient.h
+++ b/src/goabackend/goahttpclient.h
@@ -27,7 +27,9 @@
 #ifndef __GOA_HTTP_CLIENT_H__
 #define __GOA_HTTP_CLIENT_H__
 
-#include <goabackend/goabackendtypes.h>
+#include <gio/gio.h>
+#include <glib.h>
+#include <glib-object.h>
 
 G_BEGIN_DECLS
 
@@ -35,6 +37,8 @@ G_BEGIN_DECLS
 #define GOA_HTTP_CLIENT(o)          (G_TYPE_CHECK_INSTANCE_CAST ((o), GOA_TYPE_HTTP_CLIENT, GoaHttpClient))
 #define GOA_IS_HTTP_CLIENT(o)       (G_TYPE_CHECK_INSTANCE_TYPE ((o), GOA_TYPE_HTTP_CLIENT))
 
+typedef struct _GoaHttpClient GoaHttpClient;
+
 GType           goa_http_client_get_type           (void) G_GNUC_CONST;
 GoaHttpClient  *goa_http_client_new                (void);
 void            goa_http_client_check              (GoaHttpClient       *client,
diff --git a/src/goabackend/goakerberosprovider.h b/src/goabackend/goakerberosprovider.h
index 385664c..aad11e6 100644
--- a/src/goabackend/goakerberosprovider.h
+++ b/src/goabackend/goakerberosprovider.h
@@ -28,7 +28,7 @@
 #ifndef __GOA_KERBEROS_PROVIDER_H__
 #define __GOA_KERBEROS_PROVIDER_H__
 
-#include <goabackend/goabackendtypes.h>
+#include <glib-object.h>
 
 G_BEGIN_DECLS
 
@@ -36,6 +36,8 @@ G_BEGIN_DECLS
 #define GOA_KERBEROS_PROVIDER(o)     (G_TYPE_CHECK_INSTANCE_CAST ((o), GOA_TYPE_KERBEROS_PROVIDER, GoaKerberosProvider))
 #define GOA_IS_KERBEROS_PROVIDER(o)  (G_TYPE_CHECK_INSTANCE_TYPE ((o), GOA_TYPE_KERBEROS_PROVIDER))
 
+typedef struct _GoaKerberosProvider GoaKerberosProvider;
+
 GType goa_kerberos_provider_get_type (void) G_GNUC_CONST;
 
 G_END_DECLS
diff --git a/src/goabackend/goalogging.c b/src/goabackend/goalogging.c
index c1b6acd..8301884 100644
--- a/src/goabackend/goalogging.c
+++ b/src/goabackend/goalogging.c
@@ -23,6 +23,7 @@
 #include "config.h"
 #include <glib/gi18n-lib.h>
 
+#include <unistd.h>
 #include <sys/types.h>
 #include <sys/syscall.h>
 
diff --git a/src/goabackend/goalogging.h b/src/goabackend/goalogging.h
index a7edff1..1077605 100644
--- a/src/goabackend/goalogging.h
+++ b/src/goabackend/goalogging.h
@@ -27,7 +27,9 @@
 #ifndef __GOA_LOGGING_H__
 #define __GOA_LOGGING_H__
 
-#include <goabackend/goabackendtypes.h>
+#include <glib.h>
+
+#include "goabackendenums-priv.h"
 
 G_BEGIN_DECLS
 
diff --git a/src/goabackend/goaoauth2provider.h b/src/goabackend/goaoauth2provider.h
index 980f512..47e88a4 100644
--- a/src/goabackend/goaoauth2provider.h
+++ b/src/goabackend/goaoauth2provider.h
@@ -27,7 +27,7 @@
 #ifndef __GOA_OAUTH2_PROVIDER_H__
 #define __GOA_OAUTH2_PROVIDER_H__
 
-#include <goabackend/goabackendtypes.h>
+#include <goabackend/goaprovider.h>
 #include <webkit/webkit.h>
 
 G_BEGIN_DECLS
@@ -40,6 +40,7 @@ G_BEGIN_DECLS
 
 #define GOA_IS_OAUTH2_PROVIDER_CLASS(k)  (G_TYPE_CHECK_CLASS_TYPE ((k), GOA_TYPE_OAUTH2_PROVIDER))
 
+typedef struct _GoaOAuth2Provider GoaOAuth2Provider;
 typedef struct _GoaOAuth2ProviderClass GoaOAuth2ProviderClass;
 typedef struct _GoaOAuth2ProviderPrivate GoaOAuth2ProviderPrivate;
 
diff --git a/src/goabackend/goaoauthprovider.h b/src/goabackend/goaoauthprovider.h
index bbce349..7bd5a2b 100644
--- a/src/goabackend/goaoauthprovider.h
+++ b/src/goabackend/goaoauthprovider.h
@@ -27,7 +27,6 @@
 #ifndef __GOA_OAUTH_PROVIDER_H__
 #define __GOA_OAUTH_PROVIDER_H__
 
-#include <goabackend/goabackendtypes.h>
 #include <goabackend/goaprovider.h>
 #include <rest/rest-proxy-call.h>
 #include <webkit/webkit.h>
@@ -42,6 +41,7 @@ G_BEGIN_DECLS
 
 #define GOA_IS_OAUTH_PROVIDER_CLASS(k)  (G_TYPE_CHECK_CLASS_TYPE ((k), GOA_TYPE_OAUTH_PROVIDER))
 
+typedef struct _GoaOAuthProvider GoaOAuthProvider;
 typedef struct _GoaOAuthProviderClass GoaOAuthProviderClass;
 typedef struct _GoaOAuthProviderPrivate GoaOAuthProviderPrivate;
 
diff --git a/src/goabackend/goaowncloudprovider.h b/src/goabackend/goaowncloudprovider.h
index 3c6facf..158c2fa 100644
--- a/src/goabackend/goaowncloudprovider.h
+++ b/src/goabackend/goaowncloudprovider.h
@@ -27,7 +27,7 @@
 #ifndef __GOA_OWNCLOUD_PROVIDER_H__
 #define __GOA_OWNCLOUD_PROVIDER_H__
 
-#include <goabackend/goabackendtypes.h>
+#include <glib-object.h>
 
 G_BEGIN_DECLS
 
@@ -35,6 +35,8 @@ G_BEGIN_DECLS
 #define GOA_OWNCLOUD_PROVIDER(o)     (G_TYPE_CHECK_INSTANCE_CAST ((o), GOA_TYPE_OWNCLOUD_PROVIDER, GoaOwncloudProvider))
 #define GOA_IS_OWNCLOUD_PROVIDER(o)  (G_TYPE_CHECK_INSTANCE_TYPE ((o), GOA_TYPE_OWNCLOUD_PROVIDER))
 
+typedef struct _GoaOwncloudProvider GoaOwncloudProvider;
+
 GType goa_owncloud_provider_get_type (void) G_GNUC_CONST;
 
 G_END_DECLS
diff --git a/src/goabackend/goaprovider.h b/src/goabackend/goaprovider.h
index cdb081e..15a4b94 100644
--- a/src/goabackend/goaprovider.h
+++ b/src/goabackend/goaprovider.h
@@ -28,6 +28,7 @@
 #ifndef __GOA_PROVIDER_H__
 #define __GOA_PROVIDER_H__
 
+#include <gtk/gtk.h>
 #include <goabackend/goabackendtypes.h>
 
 G_BEGIN_DECLS
diff --git a/src/goabackend/goatwitterprovider.h b/src/goabackend/goatwitterprovider.h
index 8164388..9571178 100644
--- a/src/goabackend/goatwitterprovider.h
+++ b/src/goabackend/goatwitterprovider.h
@@ -27,7 +27,7 @@
 #ifndef __GOA_TWITTER_PROVIDER_H__
 #define __GOA_TWITTER_PROVIDER_H__
 
-#include <goabackend/goabackendtypes.h>
+#include <glib-object.h>
 
 G_BEGIN_DECLS
 
@@ -35,6 +35,8 @@ G_BEGIN_DECLS
 #define GOA_TWITTER_PROVIDER(o)     (G_TYPE_CHECK_INSTANCE_CAST ((o), GOA_TYPE_TWITTER_PROVIDER, GoaTwitterProvider))
 #define GOA_IS_TWITTER_PROVIDER(o)  (G_TYPE_CHECK_INSTANCE_TYPE ((o), GOA_TYPE_TWITTER_PROVIDER))
 
+typedef struct _GoaTwitterProvider GoaTwitterProvider;
+
 GType goa_twitter_provider_get_type (void) G_GNUC_CONST;
 
 G_END_DECLS
diff --git a/src/goabackend/goawindowsliveprovider.h b/src/goabackend/goawindowsliveprovider.h
index 2ed9a4d..eeacd31 100644
--- a/src/goabackend/goawindowsliveprovider.h
+++ b/src/goabackend/goawindowsliveprovider.h
@@ -29,7 +29,7 @@
 #ifndef __GOA_WINDOWS_LIVE_PROVIDER_H__
 #define __GOA_WINDOWS_LIVE_PROVIDER_H__
 
-#include <goabackend/goabackendtypes.h>
+#include <glib-object.h>
 
 G_BEGIN_DECLS
 
@@ -37,6 +37,8 @@ G_BEGIN_DECLS
 #define GOA_WINDOWS_LIVE_PROVIDER(o)     (G_TYPE_CHECK_INSTANCE_CAST ((o), GOA_TYPE_WINDOWS_LIVE_PROVIDER, GoaWindowsLiveProvider))
 #define GOA_IS_WINDOWS_LIVE_PROVIDER(o)  (G_TYPE_CHECK_INSTANCE_TYPE ((o), GOA_TYPE_WINDOWS_LIVE_PROVIDER))
 
+typedef struct _GoaWindowsLiveProvider GoaWindowsLiveProvider;
+
 GType goa_windows_live_provider_get_type (void) G_GNUC_CONST;
 
 G_END_DECLS
diff --git a/src/goabackend/goayahooprovider.h b/src/goabackend/goayahooprovider.h
index 2315703..1d87b67 100644
--- a/src/goabackend/goayahooprovider.h
+++ b/src/goabackend/goayahooprovider.h
@@ -27,7 +27,7 @@
 #ifndef __GOA_YAHOO_PROVIDER_H__
 #define __GOA_YAHOO_PROVIDER_H__
 
-#include <goabackend/goabackendtypes.h>
+#include <glib-object.h>
 
 G_BEGIN_DECLS
 
@@ -35,6 +35,8 @@ G_BEGIN_DECLS
 #define GOA_YAHOO_PROVIDER(o)     (G_TYPE_CHECK_INSTANCE_CAST ((o), GOA_TYPE_YAHOO_PROVIDER, GoaYahooProvider))
 #define GOA_IS_YAHOO_PROVIDER(o)  (G_TYPE_CHECK_INSTANCE_TYPE ((o), GOA_TYPE_YAHOO_PROVIDER))
 
+typedef struct _GoaYahooProvider GoaYahooProvider;
+
 GType goa_yahoo_provider_get_type (void) G_GNUC_CONST;
 
 G_END_DECLS
diff --git a/src/goaidentity/goaidentityservice.c b/src/goaidentity/goaidentityservice.c
index a68aa95..d4e719c 100644
--- a/src/goaidentity/goaidentityservice.c
+++ b/src/goaidentity/goaidentityservice.c
@@ -32,6 +32,8 @@
 
 #include <gcr/gcr.h>
 
+#include <goa/goa.h>
+
 #include "goaidentityenumtypes.h"
 #include "goaidentityutils.h"
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]