[egg-list-box] Avoid double emission of active-descentant-changed



commit 41553784826c5cc40f119f1722fd0fd6864b727d
Author: Matthias Clasen <mclasen redhat com>
Date:   Tue Feb 5 06:23:07 2013 -0500

    Avoid double emission of active-descentant-changed
    
    egg_list_box_update_selected already calls egg_list_box_update_cursor,
    so no need to call the two in a row. This was harmless, but it now
    causes extra emissions of a11y signals.
    https://bugzilla.gnome.org/show_bug.cgi?id=692258

 egg-list-box.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/egg-list-box.c b/egg-list-box.c
index 4d64a34..82c27ba 100644
--- a/egg-list-box.c
+++ b/egg-list-box.c
@@ -1038,8 +1038,9 @@ egg_list_box_real_focus (GtkWidget* widget, GtkDirectionType direction)
 	modify_selection_pressed = TRUE;
     }
 
-  egg_list_box_update_cursor (list_box, next_focus_child);
-  if (!modify_selection_pressed)
+  if (modify_selection_pressed)
+    egg_list_box_update_cursor (list_box, next_focus_child);
+  else
     egg_list_box_update_selected (list_box, next_focus_child);
 
   return TRUE;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]