[msitools] Replace FIXME with g_warning("FIXME:...")



commit a177ebf63ebacaccfa59c208cfe7c634db644e22
Author: Marc-Andrà Lureau <marcandre lureau gmail com>
Date:   Wed Feb 6 14:07:20 2013 +0100

    Replace FIXME with g_warning("FIXME:...")

 libmsi/debug.h           |    3 ---
 libmsi/libmsi-database.c |    4 ++--
 libmsi/storages.c        |    4 ++--
 libmsi/streams.c         |    2 +-
 4 files changed, 5 insertions(+), 8 deletions(-)
---
diff --git a/libmsi/debug.h b/libmsi/debug.h
index 7b6c903..626239d 100644
--- a/libmsi/debug.h
+++ b/libmsi/debug.h
@@ -114,9 +114,6 @@ static inline const char *debugstr_a( const char *s )  { return wine_dbgstr_an(
 #define TRACE_ON(channel)   0
 #define WARN(fmt, ...)      (void)0 // WINE_DPRINTF(WARN, __func__, fmt, ## __VA_ARGS__)
 #define WARN_ON(channel)    0
-#define FIXME(fmt, ...)     (void)0 // WINE_DPRINTF(FIXME, __func__, fmt, ## __VA_ARGS__)
-#define FIXME_ON(channel)   0
-
 
 #ifdef __cplusplus
 }
diff --git a/libmsi/libmsi-database.c b/libmsi/libmsi-database.c
index 643314e..edebd13 100644
--- a/libmsi/libmsi-database.c
+++ b/libmsi/libmsi-database.c
@@ -2200,7 +2200,7 @@ LibmsiResult _libmsi_database_open(LibmsiDatabase *db)
 
     if( !gsf_infile_msole_get_class_id (GSF_INFILE_MSOLE(stg), uuid))
     {
-        FIXME("Failed to stat storage\n");
+        g_warning("FIXME: Failed to stat storage\n");
         goto end;
     }
 
@@ -2260,7 +2260,7 @@ unsigned _libmsi_database_apply_transform( LibmsiDatabase *db,
 
     if( !gsf_infile_msole_get_class_id (GSF_INFILE_MSOLE(stg), uuid))
     {
-        FIXME("Failed to stat storage\n");
+        g_warning("FIXME: Failed to stat storage\n");
         goto end;
     }
 
diff --git a/libmsi/storages.c b/libmsi/storages.c
index 7846e69..6eb145b 100644
--- a/libmsi/storages.c
+++ b/libmsi/storages.c
@@ -104,7 +104,7 @@ static unsigned storages_view_get_row( LibmsiView *view, unsigned row, LibmsiRec
 {
     LibmsiStorageView *sv = (LibmsiStorageView *)view;
 
-    FIXME("%p %d %p\n", sv, row, rec);
+    g_warning("FIXME: %p %d %p\n", sv, row, rec);
 
     return LIBMSI_RESULT_CALL_NOT_IMPLEMENTED;
 }
@@ -128,7 +128,7 @@ static unsigned storages_view_set_row(LibmsiView *view, unsigned row, LibmsiReco
 
     if (sv->storages[row]) {
         if (mask & 1) {
-            FIXME("renaming storage via UPDATE on _Storages table\n");
+            g_warning("FIXME: renaming storage via UPDATE on _Storages table\n");
             goto done;
         }
 
diff --git a/libmsi/streams.c b/libmsi/streams.c
index 4760e18..09d8bdb 100644
--- a/libmsi/streams.c
+++ b/libmsi/streams.c
@@ -143,7 +143,7 @@ static unsigned streams_view_set_row(LibmsiView *view, unsigned row, LibmsiRecor
 
     if (sv->streams[row]) {
         if (mask & 1) {
-            FIXME("renaming stream via UPDATE on _Streams table");
+            g_warning("FIXME: renaming stream via UPDATE on _Streams table");
             goto done;
         }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]