[gimp] Bug 721067 - Opacity slider broken in "Edit/Fade [plugin]..." dialog
- From: Michael Natterer <mitch src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gimp] Bug 721067 - Opacity slider broken in "Edit/Fade [plugin]..." dialog
- Date: Thu, 26 Dec 2013 13:04:57 +0000 (UTC)
commit fb01bb37d276baedc213f28406a322cbd60b105c
Author: Michael Natterer <mitch gimp org>
Date: Thu Dec 26 13:57:27 2013 +0100
Bug 721067 - Opacity slider broken in "Edit/Fade [plugin]..." dialog
gimp_prop_opacity_entry_new(): need to pass FALSE not TRUE to
gimp_prop_scale_entry_new()'s limit_scale parameter, it has the
inverse meaning than the same boolean in gimp_scale_entry_new().
This is perhaps a bug, but we can't change that now; instead, fix the
argument names and docs of gimp_prop_scale_entry_new() to point out
the difference.
libgimpwidgets/gimppropwidgets.c | 13 ++++++++-----
1 files changed, 8 insertions(+), 5 deletions(-)
---
diff --git a/libgimpwidgets/gimppropwidgets.c b/libgimpwidgets/gimppropwidgets.c
index 9684de7..92751c9 100644
--- a/libgimpwidgets/gimppropwidgets.c
+++ b/libgimpwidgets/gimppropwidgets.c
@@ -1149,15 +1149,18 @@ gimp_prop_hscale_new (GObject *config,
* @step_increment: Step size.
* @page_increment: Page size.
* @digits: Number of digits after decimal point to display.
- * @limit_scale: %TRUE if the range of possible values of the
- * GtkSpinButton should be the same as of the GtkHScale.
- * @lower_limit: The spinbutton's lower boundary if @limit_scale is %FALSE.
- * @upper_limit: The spinbutton's upper boundary if @limit_scale is %FALSE.
+ * @scale_limits: %FALSE if the range of possible values of the
+ * GtkHScale should be the same as of the GtkSpinButton.
+ * @lower_limit: The scale's lower boundary if @scale_limits is %TRUE.
+ * @upper_limit: The scale's upper boundary if @scale_limits is %TRUE.
*
* Creates a #libgimpwidgets-gimpscaleentry (slider and spin button)
* to set and display the value of the specified double property. See
* gimp_scale_entry_new() for more information.
*
+ * Note that the @scale_limits boolean is the inverse of
+ * gimp_scale_entry_new()'s "constrain" parameter.
+ *
* Return value: The #GtkSpinButton's #GtkAdjustment.
*
* Since GIMP 2.4
@@ -1314,7 +1317,7 @@ gimp_prop_opacity_entry_new (GObject *config,
adjustment = gimp_prop_scale_entry_new (config, property_name,
table, column, row, label,
0.01, 0.1, 1,
- TRUE, 0.0, 0.0);
+ FALSE, 0.0, 0.0);
if (adjustment)
{
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]