[glade/glade-3-16] GladeWidget: Removed get_toplevel() cache. This micro optimization in no longer needed and it was in
- From: Juan Pablo Ugarte <jpu src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glade/glade-3-16] GladeWidget: Removed get_toplevel() cache. This micro optimization in no longer needed and it was in
- Date: Wed, 18 Dec 2013 02:56:12 +0000 (UTC)
commit 35086c0f25d4bfd16cafb4550a45e9b9eacba85b
Author: Juan Pablo Ugarte <juanpablougarte gmail com>
Date: Tue Dec 17 16:05:14 2013 -0300
GladeWidget: Removed get_toplevel() cache.
This micro optimization in no longer needed and it was incomplete.
gladeui/glade-widget.c | 10 ----------
1 files changed, 0 insertions(+), 10 deletions(-)
---
diff --git a/gladeui/glade-widget.c b/gladeui/glade-widget.c
index df3a965..e9a23ac 100644
--- a/gladeui/glade-widget.c
+++ b/gladeui/glade-widget.c
@@ -149,8 +149,6 @@ struct _GladeWidgetPrivate {
GtkTreeModel *signal_model; /* Signal model (or NULL if not yet requested) */
- GladeWidget *cached_toplevel; /* Used to speed up glade_widget_get_toplevel */
-
/* Construct parameters: */
GladeWidget *construct_template;
GladeCreateReason construct_reason;
@@ -3643,9 +3641,6 @@ glade_widget_set_parent (GladeWidget * widget, GladeWidget * parent)
old_parent = widget->priv->parent;
widget->priv->parent = parent;
- /* unset toplevel cache used in glade_widget_get_toplevel() */
- widget->priv->cached_toplevel = NULL;
-
/* Set packing props only if the object is actually parented by 'parent'
* (a subsequent call should come from glade_command after parenting).
*/
@@ -3757,14 +3752,9 @@ glade_widget_get_toplevel (GladeWidget * widget)
GladeWidget *toplevel = widget;
g_return_val_if_fail (GLADE_IS_WIDGET (widget), NULL);
- if (widget->priv->cached_toplevel)
- return widget->priv->cached_toplevel;
-
while (toplevel->priv->parent)
toplevel = toplevel->priv->parent;
- widget->priv->cached_toplevel = toplevel;
-
return toplevel;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]