[gnome-shell/wip/new-notifications: 8/13] messageTray: Remove addBody as a public API
- From: Jasper St. Pierre <jstpierre src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/wip/new-notifications: 8/13] messageTray: Remove addBody as a public API
- Date: Fri, 13 Dec 2013 16:54:17 +0000 (UTC)
commit 8f11a2b0a0f08248ecb659ccde3770c7af96ca3e
Author: Jasper St. Pierre <jstpierre mecheye net>
Date: Wed Dec 4 22:56:59 2013 -0500
messageTray: Remove addBody as a public API
As it's unused.
js/ui/messageTray.js | 35 ++++++++++-------------------------
1 files changed, 10 insertions(+), 25 deletions(-)
---
diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index 52dfb0d..c0bc62c 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -444,15 +444,14 @@ const NotificationApplicationPolicy = new Lang.Class({
// unless 'customContent' parameter with the value 'true' is specified
// in @params.
//
-// Additional notification content can be added with addActor() and
-// addBody() methods. The notification content is put inside a
-// scrollview, so if it gets too tall, the notification will scroll
-// rather than continue to grow. In addition to this main content
-// area, there is also a single-row action area, which is not
-// scrolled and can contain a single actor. The action area can
-// be set by calling setActionArea() method. There is also a
-// convenience method addButton() for adding a button to the action
-// area.
+// Additional notification content can be added with addActor(). The
+// notification content is put inside a scrollview, so if it gets too
+// tall, the notification will scroll rather than continue to grow.
+// In addition to this main content area, there is also a single-row
+// action area, which is not scrolled and can contain a single actor.
+// The action area can be set by calling setActionArea() method. There
+// is also a convenience method addButton() for adding a button to the
+// action area.
//
// If @params contains a 'customContent' parameter with the value %true,
// then @banner will not be shown in the body of the notification when the
@@ -710,25 +709,11 @@ const Notification = new Lang.Class({
this.updated();
},
- // addBody:
- // @text: the text
- // @markup: %true if @text contains pango markup
- // @style: style to use when adding the actor containing the text
- //
- // Adds a multi-line label containing @text to the notification.
- //
- // Return value: the newly-added label
- addBody: function(text, markup, style) {
- let label = new URLHighlighter(text, true, markup);
-
- this.addActor(label.actor, style);
- return label.actor;
- },
-
_addBannerBody: function() {
if (this.bannerBodyText && !this._bannerBodyAdded) {
+ let label = new URLHighlighter(this.bannerBodyText, true, this.bannerBodyMarkup);
+ this.addActor(label.actor);
this._bannerBodyAdded = true;
- this.addBody(this.bannerBodyText, this.bannerBodyMarkup);
}
},
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]