[glibmm] Glib::ustring: Delete an obsolete TODO comment



commit 217e7444731f11e7b808bfde677a25a180337139
Author: Kjell Ahlstedt <kjell ahlstedt bredband net>
Date:   Mon Dec 9 18:30:23 2013 +0100

    Glib::ustring: Delete an obsolete TODO comment
    
    * glib/glibmm/ustring.cc: The comment added 2007-08-12 by commit
    https://git.gnome.org/browse/glibmm/commit/?id=132b0ceb8c30ef82a6c11635eff8e7b41feba357
    is obsolete or a misunderstanding. A std::wostream requires a wchar_t string
    as input from the C++ code, but the character encoding of a written file is
    determined by the std::wostream's std::locale.

 glib/glibmm/ustring.cc |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
---
diff --git a/glib/glibmm/ustring.cc b/glib/glibmm/ustring.cc
index 0d31d48..6cb4b1f 100644
--- a/glib/glibmm/ustring.cc
+++ b/glib/glibmm/ustring.cc
@@ -1389,9 +1389,6 @@ std::wostream& operator<<(std::wostream& os, const ustring& utf8_string)
   const ScopedPtr<gunichar2> buf (g_utf8_to_utf16(utf8_string.raw().data(),
                                                   utf8_string.raw().size(), 0, 0, &error));
 #else
-  // TODO: For some reason the conversion from UTF-8 to WCHAR_T doesn't work
-  // with g_convert(), while iconv on the command line handles it just fine.
-  // Maybe a bug in GLib?
   const ScopedPtr<char> buf (g_convert(utf8_string.raw().data(), utf8_string.raw().size(),
                                        "WCHAR_T", "UTF-8", 0, 0, &error));
 #endif // !(__STDC_ISO_10646__ || G_OS_WIN32)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]