[gnome-initial-setup] language: Don't go to the next page automatically



commit 57d7c8a4d545d1cf2731987d1b9462bf7996607e
Author: Matthias Clasen <mclasen redhat com>
Date:   Fri Dec 6 17:46:50 2013 -0500

    language: Don't go to the next page automatically
    
    This made sense with a tree view, where selection (single click)
    and activation (double click) are distinct. With the current
    list view, it is much clearer to let the user click 'Next'
    explicitly.

 .../pages/language/gis-language-page.c             |   20 --------------------
 1 files changed, 0 insertions(+), 20 deletions(-)
---
diff --git a/gnome-initial-setup/pages/language/gis-language-page.c 
b/gnome-initial-setup/pages/language/gis-language-page.c
index d79f924..34b1599 100644
--- a/gnome-initial-setup/pages/language/gis-language-page.c
+++ b/gnome-initial-setup/pages/language/gis-language-page.c
@@ -46,7 +46,6 @@ struct _GisLanguagePagePrivate
   GDBusProxy *localed;
   GPermission *permission;
   const gchar *new_locale_id;
-  guint selection_done_source;
 
   GCancellable *cancellable;
 };
@@ -108,14 +107,6 @@ user_loaded (GObject    *object,
   g_free (new_locale_id);
 }
 
-static gboolean
-_selection_done (gpointer driver)
-{
-  gis_assistant_next_page (gis_driver_get_assistant (GIS_DRIVER (driver)));
-
-  return FALSE;
-}
-
 static void
 language_changed (CcLanguageChooser  *chooser,
                   GParamSpec         *pspec,
@@ -125,12 +116,6 @@ language_changed (CcLanguageChooser  *chooser,
   ActUser *user;
   GisDriver *driver;
 
-  if (priv->selection_done_source > 0)
-    {
-      g_source_remove (priv->selection_done_source);
-      priv->selection_done_source = 0;
-    }
-
   priv->new_locale_id = cc_language_chooser_get_language (chooser);
   driver = GIS_PAGE (page)->driver;
 
@@ -159,9 +144,6 @@ language_changed (CcLanguageChooser  *chooser,
                       g_strdup (priv->new_locale_id));
 
   gis_driver_set_user_language (driver, priv->new_locale_id);
-
-  priv->selection_done_source = g_timeout_add (500, _selection_done,
-                                               (gpointer)driver);
 }
 
 static void
@@ -234,8 +216,6 @@ gis_language_page_dispose (GObject *object)
   GisLanguagePage *page = GIS_LANGUAGE_PAGE (object);
   GisLanguagePagePrivate *priv = gis_language_page_get_instance_private (page);
 
-  if (priv->selection_done_source > 0)
-    g_source_remove (priv->selection_done_source);
   g_clear_object (&priv->permission);
   g_clear_object (&priv->localed);
   g_clear_object (&priv->cancellable);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]