[gnome-shell] viewSelector: Give the active page key focus when it is shown



commit ec2bb039ae7ab3f3504bfe0fdba6c715f5a838fd
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Mon Nov 4 17:23:28 2013 -0500

    viewSelector: Give the active page key focus when it is shown
    
    Rather than implement special focus policies like only allowing keynav
    when pressing down, simply give the active page key focus when entering
    the overview.
    
    This may break stuff, as it's somewhat of a tricky patch to get right.
    Testing this one would be super appreciated.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=644306

 js/ui/viewSelector.js |   11 ++---------
 1 files changed, 2 insertions(+), 9 deletions(-)
---
diff --git a/js/ui/viewSelector.js b/js/ui/viewSelector.js
index 0bc0f20..75ef3ad 100644
--- a/js/ui/viewSelector.js
+++ b/js/ui/viewSelector.js
@@ -186,6 +186,7 @@ const ViewSelector = new Lang.Class({
         params = Params.parse(params, { a11yFocus: null });
 
         let page = new St.Bin({ child: actor,
+                                visible: false,
                                 x_align: St.Align.START,
                                 y_align: St.Align.START,
                                 x_fill: true,
@@ -210,7 +211,7 @@ const ViewSelector = new Lang.Class({
             oldPage.hide();
 
         this.emit('page-empty');
-
+        this._activePage.navigate_focus(null, Gtk.DirectionType.TAB_FORWARD, false);
         this._activePage.show();
         Tweener.addTween(this._activePage,
             { opacity: 255,
@@ -281,14 +282,6 @@ const ViewSelector = new Lang.Class({
             return true;
         } else if (this._shouldTriggerSearch(symbol)) {
             this.startSearch(event);
-        } else if (!this._searchActive) {
-            if (symbol == Clutter.Tab || symbol == Clutter.Down) {
-                this._activePage.navigate_focus(null, Gtk.DirectionType.TAB_FORWARD, false);
-                return true;
-            } else if (symbol == Clutter.ISO_Left_Tab) {
-                this._activePage.navigate_focus(null, Gtk.DirectionType.TAB_BACKWARD, false);
-                return true;
-            }
         }
         return false;
     },


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]