[evolution-data-server/gnome-3-10] EBookBackendCache: Remove an unnecessary NULL check.
- From: Matthew Barnes <mbarnes src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution-data-server/gnome-3-10] EBookBackendCache: Remove an unnecessary NULL check.
- Date: Wed, 4 Dec 2013 01:27:44 +0000 (UTC)
commit f7b21d07f5bdc3a40979c89d75ffc40c13abeca2
Author: Philip Withnall <philip withnall collabora co uk>
Date: Tue Dec 3 15:26:57 2013 -0500
EBookBackendCache: Remove an unnecessary NULL check.
A newly-created EContact is never NULL, so the check is redundant.
It was confusing the static analyser.
https://bugzilla.gnome.org/719533
(cherry picked from commit 047c4470a554c6f4e9a5a83b414d2d65ef759436)
addressbook/libedata-book/e-book-backend-cache.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/addressbook/libedata-book/e-book-backend-cache.c
b/addressbook/libedata-book/e-book-backend-cache.c
index 105ef77..00e0206 100644
--- a/addressbook/libedata-book/e-book-backend-cache.c
+++ b/addressbook/libedata-book/e-book-backend-cache.c
@@ -215,7 +215,7 @@ e_book_backend_cache_get_contacts (EBookBackendCache *cache,
if (vcard_str && !strncmp (vcard_str, "BEGIN:VCARD", 11)) {
contact = e_contact_new_from_vcard (vcard_str);
uid = e_contact_get_const (contact, E_CONTACT_UID);
- if (contact && uid && *uid &&(query && e_book_backend_sexp_match_contact (sexp,
contact)))
+ if (uid && *uid && (query && e_book_backend_sexp_match_contact (sexp, contact)))
list = g_list_prepend (list, contact);
else
g_object_unref (contact);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]