[evolution-data-server] camel_store_get_inbox_folder_sync: Remove lock.
- From: Matthew Barnes <mbarnes src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution-data-server] camel_store_get_inbox_folder_sync: Remove lock.
- Date: Sun, 1 Dec 2013 15:59:12 +0000 (UTC)
commit 270c393d47c750894cb18fcd16e8a925b9e30582
Author: Matthew Barnes <mbarnes redhat com>
Date: Sun Dec 1 09:43:25 2013 -0500
camel_store_get_inbox_folder_sync: Remove lock.
Don't see any reason to lock here. Providers ought to be able to handle
this concurrently with other methods. Let any side-effects reveal them-
selves so we can fix them or document them.
camel/camel-store.c | 10 ----------
1 files changed, 0 insertions(+), 10 deletions(-)
---
diff --git a/camel/camel-store.c b/camel/camel-store.c
index 5cfff6c..53d883b 100644
--- a/camel/camel-store.c
+++ b/camel/camel-store.c
@@ -1788,20 +1788,10 @@ camel_store_get_inbox_folder_sync (CamelStore *store,
class = CAMEL_STORE_GET_CLASS (store);
g_return_val_if_fail (class->get_inbox_folder_sync != NULL, NULL);
- camel_store_lock (store);
-
- /* Check for cancellation after locking. */
- if (g_cancellable_set_error_if_cancelled (cancellable, error)) {
- camel_store_unlock (store);
- return NULL;
- }
-
folder = class->get_inbox_folder_sync (store, cancellable, error);
CAMEL_CHECK_GERROR (
store, get_inbox_folder_sync, folder != NULL, error);
- camel_store_unlock (store);
-
return folder;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]