[gtk+/gtk-3-8] Avoid integer overflow



commit 727182f0f92bc61bdeb3222b57e3f51c8abca1ef
Author: Matthias Clasen <mclasen redhat com>
Date:   Sat Jun 29 22:06:54 2013 -0400

    Avoid integer overflow
    
    Use g_malloc_n in gdk_cairo_set_source_pixbuf when allocating
    a large block of memory, to avoid integer overflow.
    
    Pointed out by Bert Massop in
    https://bugzilla.gnome.org/show_bug.cgi?id=703220

 gdk/gdkcairo.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/gdk/gdkcairo.c b/gdk/gdkcairo.c
index 19bed04..2e1d8dc 100644
--- a/gdk/gdkcairo.c
+++ b/gdk/gdkcairo.c
@@ -213,7 +213,7 @@ gdk_cairo_set_source_pixbuf (cairo_t         *cr,
     format = CAIRO_FORMAT_ARGB32;
 
   cairo_stride = cairo_format_stride_for_width (format, width);
-  cairo_pixels = g_malloc (height * cairo_stride);
+  cairo_pixels = g_malloc_n (height, cairo_stride);
   surface = cairo_image_surface_create_for_data ((unsigned char *)cairo_pixels,
                                                  format,
                                                  width, height, cairo_stride);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]