[gnome-software] Do not abort refining applications of one desktop file is corrupt

[Richard Hughes <rhughes src gnome org>]

commit f3649ba5ed9fe70ef0abfa6faa791d7db699ddad
Author: Richard Hughes <richard hughsie com>
Date:   Thu Aug 29 11:17:38 2013 +0100

    Do not abort refining applications of one desktop file is corrupt

 src/plugins/gs-plugin-datadir-apps.c |   15 ++++++++++++---
 1 files changed, 12 insertions(+), 3 deletions(-)
---
diff --git a/src/plugins/gs-plugin-datadir-apps.c b/src/plugins/gs-plugin-datadir-apps.c
index 0829f06..a488038 100644
--- a/src/plugins/gs-plugin-datadir-apps.c
+++ b/src/plugins/gs-plugin-datadir-apps.c
@@ -226,6 +226,7 @@ gs_plugin_refine (GsPlugin *plugin,
        const gchar *tmp;
        gboolean ret = TRUE;
        GList *l;
+       GError *error_local = NULL;
        GsApp *app;
 
        for (l = list; l != NULL; l = l->next) {
@@ -236,14 +237,22 @@ gs_plugin_refine (GsPlugin *plugin,
                ret = gs_plugin_datadir_apps_extract_desktop_data (plugin,
                                                                   app,
                                                                   tmp,
-                                                                  error);
-               if (!ret)
-                       goto out;
+                                                                  &error_local);
+               if (!ret) {
+                       g_warning ("failed to extract desktop data for %s: %s",
+                                  gs_app_get_id (app),
+                                  error_local->message);
+                       g_clear_error (&error_local);
+                       continue;
+               }
 
                /* we know it's installed as we read the desktop file */
                if (gs_app_get_state (app) == GS_APP_STATE_UNKNOWN)
                        gs_app_set_state (app, GS_APP_STATE_INSTALLED);
        }
+
+       /* success */
+       ret = TRUE;
 out:
        return ret;
 }