[goffice] Fix NULL pointer issue in line plots. [#706663]



commit aa5ee58f690a0f5e061b5138434866e9f1608afa
Author: Jean Brefort <jean brefort normalesup org>
Date:   Fri Aug 23 20:00:45 2013 +0200

    Fix NULL pointer issue in line plots. [#706663]

 ChangeLog                      |    5 +++++
 NEWS                           |    3 +++
 plugins/plot_barcol/gog-line.c |    2 +-
 3 files changed, 9 insertions(+), 1 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index dd2bf3b..f2bad02 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2013-08-23  Jean Brefort  <jean brefort normalesup org>
+
+       * plugins/plot_barcol/gog-line.c (gog_line_view_render): always allocate
+       enough room for points. [#706663]
+
 2013-08-20  Morten Welinder  <terra gnome org>
 
        * goffice/canvas/goc-canvas.c (goc_canvas_draw): Fix redraw issues
diff --git a/NEWS b/NEWS
index 8401f14..0e7d459 100644
--- a/NEWS
+++ b/NEWS
@@ -3,6 +3,9 @@ goffice 0.10.6:
 Alexander Larsson:
        * Fix gtk+ 3.9 redraw problems.  [#703124]
 
+Jean:
+       * Fix NULL pointer issue in line plots. [#706663]
+
 --------------------------------------------------------------------------
 goffice 0.10.5:
 
diff --git a/plugins/plot_barcol/gog-line.c b/plugins/plot_barcol/gog-line.c
index 2a0e188..edf297c 100644
--- a/plugins/plot_barcol/gog-line.c
+++ b/plugins/plot_barcol/gog-line.c
@@ -993,7 +993,7 @@ gog_line_view_render (GogView *view, GogViewAllocation const *bbox)
                        interpolations[i] = GO_LINE_INTERPOLATION_SPLINE;
 
                if (!is_area_plot)
-                       points[i] = g_malloc (sizeof (Point) * (lengths[i]));
+                       points[i] = g_malloc (sizeof (Point) * (type == GOG_1_5D_NORMAL? lengths[i]: 
num_elements));
 
                errors[i] = series[i]->errors;
                if (gog_error_bar_is_visible (series[i]->errors))


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]