[gnome-music] player: Has next and previous track should be false if there's no playlist



commit 2f8b7838a89f69d0b7172f9c5b47c1f77fce247b
Author: Arnel A. Borja <arnelborja src gnome org>
Date:   Mon Aug 19 10:12:38 2013 +0800

    player: Has next and previous track should be false if there's no playlist
    
    This prevents a crash when there is no selected playlist yet and an MPRIS
    client tries to get properties of org.mpris.MediaPlayer2.Player interface.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=705855

 gnomemusic/player.py |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)
---
diff --git a/gnomemusic/player.py b/gnomemusic/player.py
index bbf6bae..b342ea8 100644
--- a/gnomemusic/player.py
+++ b/gnomemusic/player.py
@@ -190,14 +190,18 @@ class Player(GObject.GObject):
         return previousTrack
 
     def has_next(self):
-        if self.repeat in [RepeatType.ALL, RepeatType.SONG, RepeatType.SHUFFLE]:
+        if not self.currentTrack:
+            return False
+        elif self.repeat in [RepeatType.ALL, RepeatType.SONG, RepeatType.SHUFFLE]:
             return True
         else:
             tmp = self.currentTrack.copy()
             return self.playlist.iter_next(tmp) is not None
 
     def has_previous(self):
-        if self.repeat in [RepeatType.ALL, RepeatType.SONG, RepeatType.SHUFFLE]:
+        if not self.currentTrack:
+            return False
+        elif self.repeat in [RepeatType.ALL, RepeatType.SONG, RepeatType.SHUFFLE]:
             return True
         else:
             tmp = self.currentTrack.copy()


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]