[gnome-chess] Remove show history option
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-chess] Remove show history option
- Date: Sun, 18 Aug 2013 19:25:58 +0000 (UTC)
commit bc62e3dd41892db080a0b6f79dc2b1a27057a893
Author: Michael Catanzaro <mcatanzaro gnome org>
Date: Sun Aug 18 14:18:26 2013 -0500
Remove show history option
There's really no benefit to being able to hide the history bar. You
currently gain a bit of space, but that's because this option breaks
timed games by hiding the timers. This option might make sense after a
bit of a UI redesign, but I don't see that happening anytime soon.
https://bugzilla.gnome.org/show_bug.cgi?id=705046
data/org.gnome.gnome-chess.gschema.xml.in | 5 -----
data/preferences.ui | 16 ----------------
src/gnome-chess.vala | 4 ----
3 files changed, 0 insertions(+), 25 deletions(-)
---
diff --git a/data/org.gnome.gnome-chess.gschema.xml.in b/data/org.gnome.gnome-chess.gschema.xml.in
index 32c9c32..365e770 100644
--- a/data/org.gnome.gnome-chess.gschema.xml.in
+++ b/data/org.gnome.gnome-chess.gschema.xml.in
@@ -66,11 +66,6 @@
<_summary>A flag to enable board numbering</_summary>
<_description>A flag to enable board numbering</_description>
</key>
- <key name="show-history" type="b">
- <default>true</default>
- <_summary>A flag to enable the move history browser</_summary>
- <_description>A flag to enable the move history browser</_description>
- </key>
<key name="save-directory" type="s">
<default>''</default>
<_summary>The directory to open the save game dialog in</_summary>
diff --git a/data/preferences.ui b/data/preferences.ui
index 558c103..ceb4404 100644
--- a/data/preferences.ui
+++ b/data/preferences.ui
@@ -592,22 +592,6 @@
</packing>
</child>
<child>
- <object class="GtkCheckButton" id="show_history_check">
- <property name="label" translatable="yes" comments="Preferences Dialog: Check box
for selecting if history browser is visible">Show _history</property>
- <property name="visible">True</property>
- <property name="can_focus">True</property>
- <property name="receives_default">False</property>
- <property name="use_underline">True</property>
- <property name="xalign">0.5</property>
- <property name="draw_indicator">True</property>
- </object>
- <packing>
- <property name="expand">False</property>
- <property name="fill">False</property>
- <property name="position">4</property>
- </packing>
- </child>
- <child>
<object class="GtkCheckButton" id="show_move_hints_check">
<property name="label" translatable="yes" comments="Preferences Dialog: Check box
for selecting if move hints are visible">_Move hints</property>
<property name="visible">True</property>
diff --git a/src/gnome-chess.vala b/src/gnome-chess.vala
index ed7a634..e00e619 100644
--- a/src/gnome-chess.vala
+++ b/src/gnome-chess.vala
@@ -158,7 +158,6 @@ public class Application : Gtk.Application
history_combo = (Gtk.ComboBox) builder.get_object ("history_combo");
white_time_label = (Gtk.Widget) builder.get_object ("white_time_label");
black_time_label = (Gtk.Widget) builder.get_object ("black_time_label");
- settings.bind ("show-history", builder.get_object ("navigation_box"), "visible",
SettingsBindFlags.DEFAULT);
var view_box = (Gtk.VBox) builder.get_object ("view_box");
view_container = (Gtk.Container) builder.get_object ("view_container");
builder.connect_signals (this);
@@ -1426,8 +1425,6 @@ public class Application : Gtk.Application
"active", SettingsBindFlags.DEFAULT);
settings.bind ("show-move-hints", preferences_builder.get_object ("show_move_hints_check"),
"active", SettingsBindFlags.DEFAULT);
- settings.bind ("show-history", preferences_builder.get_object ("show_history_check"),
- "active", SettingsBindFlags.DEFAULT);
settings.bind ("show-3d", preferences_builder.get_object ("show_3d_check"),
"active", SettingsBindFlags.DEFAULT);
settings.bind ("show-3d-smooth", preferences_builder.get_object ("show_3d_smooth_check"),
@@ -1454,7 +1451,6 @@ public class Application : Gtk.Application
ai_combo.set_active (0);
settings.set_string ("opponent", "human");
}
- settings.bind ("show-history", ai_combo, "visible", SettingsBindFlags.SET);
difficulty_combo = (Gtk.ComboBox) preferences_builder.get_object ("difficulty_combo");
set_combo (difficulty_combo, 1, settings.get_string ("difficulty"));
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]