[gnome-music: 1/2] widgets: Cache vadjusment in AllArtistsAlbums.



commit ddd34f22a4d8cf418ab5eed7754b475799a93134
Author: Jackson Isaac <jacksonisaac2008 gmail com>
Date:   Sat Aug 17 18:50:17 2013 +0530

    widgets: Cache vadjusment in AllArtistsAlbums.

 gnomemusic/widgets.py |   14 ++++++--------
 1 files changed, 6 insertions(+), 8 deletions(-)
---
diff --git a/gnomemusic/widgets.py b/gnomemusic/widgets.py
index 71fa00a..50ba741 100644
--- a/gnomemusic/widgets.py
+++ b/gnomemusic/widgets.py
@@ -402,6 +402,7 @@ class AllArtistsAlbums(ArtistAlbums):
         self._load_more = LoadMoreButton(self._get_remaining_item_count)
         self.pack_end(self._load_more.widget, False, False, 0)
         self._load_more.widget.connect('clicked', self._populate)
+        self.vadjustment = self._scrolledWindow.get_vadjustment()
         self._connect_view()
         self._populate()
 
@@ -410,11 +411,9 @@ class AllArtistsAlbums(ArtistAlbums):
 
     def _connect_view(self):
         self._adjustmentValueId =\
-            self._scrolledWindow.get_vadjustment()\
-                .connect('value-changed', self._on_scrollbar_visible)
+            self.vadjustment.connect('value-changed', self._on_scrollbar_visible)
         self._adjustmentChangedId =\
-            self._scrolledWindow.get_vadjustment().connect(
-                'changed', self._on_scrollbar_visible)
+            self.vadjustment.connect('changed', self._on_scrollbar_visible)
         self._scrollbarVisibleId =\
             self._scrolledWindow.get_vscrollbar().connect(
                 'notify::visible',
@@ -426,7 +425,6 @@ class AllArtistsAlbums(ArtistAlbums):
 
     def _on_scrolled_win_change(self, scrollbar=None, pspec=None, data=None):
         vScrollbar = self._scrolledWindow.get_vscrollbar()
-        adjustment = self._scrolledWindow.get_vadjustment()
         revealAreaHeight = 32
 
         # if there's no vscrollbar, or if it's not visible, hide the button
@@ -434,9 +432,9 @@ class AllArtistsAlbums(ArtistAlbums):
             self._load_more.set_block(True)
             return
 
-        value = adjustment.get_value()
-        upper = adjustment.get_upper()
-        page_size = adjustment.get_page_size()
+        value = self.vadjustment.get_value()
+        upper = self.vadjustment.get_upper()
+        page_size = self.vadjustment.get_page_size()
         end = False
 
         # special case this values which happen at construction


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]