[easytag/wip/clang-analyzer: 8/14] Avoid memory leak in Rename_Directory()



commit 1235ca9469d3d625f1b5a38cf3da504c76469794
Author: David King <amigadave amigadave com>
Date:   Mon Aug 12 16:36:03 2013 +0100

    Avoid memory leak in Rename_Directory()
    
    Found with the Clang static analyzer.

 src/browser.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
---
diff --git a/src/browser.c b/src/browser.c
index b4d0749..2d8cf90 100644
--- a/src/browser.c
+++ b/src/browser.c
@@ -3754,16 +3754,16 @@ Rename_Directory (void)
 
         gtk_dialog_run(GTK_DIALOG(msgdialog));
         gtk_widget_destroy(msgdialog);
-        g_free(directory_new_name);
         g_free(directory_new_name_file);
     }
 
+    g_free (directory_new_name);
+
     /* If the directory name haven't been changed, we do nothing! */
     if (directory_last_name && directory_new_name_file
     && strcmp(directory_last_name,directory_new_name_file)==0)
     {
         Destroy_Rename_Directory_Window();
-        g_free(directory_new_name);
         g_free(directory_new_name_file);
         return;
     }
@@ -3825,7 +3825,6 @@ Rename_Directory (void)
             gtk_dialog_run(GTK_DIALOG(msgdialog));
             gtk_widget_destroy(msgdialog);
 
-            g_free(directory_new_name);
             g_free(directory_new_name_file);
             g_free(last_path);
             g_free(last_path_utf8);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]