[evolution-data-server] CamelIMAPXServer: Remove "expunged" list.



commit 48ff068273a9e9c4ca7c5713219d62f105d28f4c
Author: Matthew Barnes <mbarnes redhat com>
Date:   Wed Aug 7 16:39:45 2013 +0200

    CamelIMAPXServer: Remove "expunged" list.
    
    The "expunged" list is populated with message UIDs and occasionally
    cleared, but CamelIMAPXServer does not actually use it for anything.

 camel/camel-imapx-server.c |   12 ++----------
 camel/camel-imapx-server.h |    4 ----
 2 files changed, 2 insertions(+), 14 deletions(-)
---
diff --git a/camel/camel-imapx-server.c b/camel/camel-imapx-server.c
index c8519df..00c9545 100644
--- a/camel/camel-imapx-server.c
+++ b/camel/camel-imapx-server.c
@@ -1440,8 +1440,6 @@ imapx_expunge_uid_from_summary (CamelIMAPXServer *is,
                camel_folder_summary_remove_uid (folder->summary, uid);
        }
 
-       is->expunged = g_list_prepend (is->expunged, uid);
-
        camel_folder_change_info_remove_uid (is->changes, uid);
 
        if (imapx_in_idle (is)) {
@@ -1449,9 +1447,6 @@ imapx_expunge_uid_from_summary (CamelIMAPXServer *is,
                imapx_update_store_summary (folder);
                camel_folder_changed (folder, is->changes);
 
-               g_list_free_full (is->expunged, (GDestroyNotify) g_free);
-               is->expunged = NULL;
-
                camel_folder_change_info_clear (is->changes);
        }
 
@@ -1624,7 +1619,8 @@ imapx_untagged_vanished (CamelIMAPXServer *is,
 
        uid_list = g_list_reverse (uid_list);
        camel_folder_summary_remove_uids (folder->summary, uid_list);
-       is->expunged = g_list_concat (is->expunged, uid_list);
+
+       g_list_free_full (uid_list, (GDestroyNotify) g_free);
        g_ptr_array_free (uids, TRUE);
 
        g_object_unref (folder);
@@ -2825,9 +2821,6 @@ imapx_completion (CamelIMAPXServer *is,
 
                camel_folder_summary_save_to_db (folder->summary, NULL);
 
-               g_list_free_full (is->expunged, (GDestroyNotify) g_free);
-               is->expunged = NULL;
-
                imapx_update_store_summary (folder);
                camel_folder_changed (folder, is->changes);
                camel_folder_change_info_clear (is->changes);
@@ -7211,7 +7204,6 @@ camel_imapx_server_init (CamelIMAPXServer *is)
 
        is->state = IMAPX_DISCONNECTED;
 
-       is->expunged = NULL;
        is->changes = camel_folder_change_info_new ();
        is->parser_quit = FALSE;
 
diff --git a/camel/camel-imapx-server.h b/camel/camel-imapx-server.h
index d54c076..b7176fb 100644
--- a/camel/camel-imapx-server.h
+++ b/camel/camel-imapx-server.h
@@ -145,10 +145,6 @@ struct _CamelIMAPXServer {
        guint32 recent;
        guint32 mode;
 
-       /* any expunges that happened from the last command, they are
-        * processed after the command completes. */
-       GList *expunged;
-
        GThread *parser_thread;
        /* Used for canceling operations as well as signaling parser thread to disconnnect/quit */
        GCancellable *cancellable;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]