[glibmm] Gio::ActionGroup: Add more TODOs about methods that should be templated.
- From: Murray Cumming <murrayc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glibmm] Gio::ActionGroup: Add more TODOs about methods that should be templated.
- Date: Tue, 6 Aug 2013 19:19:07 +0000 (UTC)
commit bad0117c36e06cf4b94d39f2d193e61fa30ff2bc
Author: Murray Cumming <murrayc murrayc com>
Date: Tue Aug 6 21:17:47 2013 +0200
Gio::ActionGroup: Add more TODOs about methods that should be templated.
Unforunately it is too late to correct this.
gio/src/actiongroup.hg | 10 ++++++++++
gio/src/simpleaction.hg | 2 ++
2 files changed, 12 insertions(+), 0 deletions(-)
---
diff --git a/gio/src/actiongroup.hg b/gio/src/actiongroup.hg
index 777fb86..2c60246 100644
--- a/gio/src/actiongroup.hg
+++ b/gio/src/actiongroup.hg
@@ -66,6 +66,7 @@ public:
#m4
_CONVERSION(`gchar**',`std::vector<Glib::ustring>',`Glib::ArrayHandler<Glib::ustring>::array_to_vector($3,
Glib::OWNERSHIP_DEEP)')
_WRAP_METHOD(std::vector<Glib::ustring> list_actions() const, g_action_group_list_actions)
+ //TODO: Add templated method, renaming this to query_action_variant).
_WRAP_METHOD(bool query_action(const Glib::ustring& action_name, bool& enabled{>>}, Glib::VariantType&
parameter_type{>>?}, Glib::VariantBase& state_hint{.>>}, Glib::VariantType& state_type{.>>?},
Glib::VariantBase& state{.>>?}), g_action_group_query_action)
_WRAP_METHOD(bool get_action_enabled(const Glib::ustring& action_name) const,
g_action_group_get_action_enabled)
@@ -73,14 +74,23 @@ public:
_WRAP_METHOD(Glib::VariantType get_action_parameter_type(const Glib::ustring& action_name) const,
g_action_group_get_action_parameter_type)
_WRAP_METHOD(Glib::VariantType get_action_state_type(const Glib::ustring& action_name) const,
g_action_group_get_action_state_type)
+ //TODO: Add templated method, renaming this to get_actino_state_hint_variant(). See
Action::get_state_hint().
_WRAP_METHOD(Glib::VariantContainerBase get_action_state_hint(const Glib::ustring& action_name) const,
g_action_group_get_action_state_hint)
+
+ //TODO: Add templated method, renaming this to get_action_state_variant().
_WRAP_METHOD(Glib::VariantBase get_action_state(const Glib::ustring& action_name) const,
g_action_group_get_action_state)
+ //TODO: Add templated method, renaming this to change_action_state_variant().
_WRAP_METHOD(void change_action_state(const Glib::ustring& action_name, const Glib::VariantBase& value),
g_action_group_change_action_state)
+
+ //TODO: Add templated method, renaming this to activate_action_variant().
_WRAP_METHOD(void activate_action(const Glib::ustring& action_name, const Glib::VariantBase& parameter),
g_action_group_activate_action)
+
_WRAP_METHOD(void action_added(const Glib::ustring& action_name), g_action_group_action_added)
_WRAP_METHOD(void action_removed(const Glib::ustring& action_name), g_action_group_action_removed)
_WRAP_METHOD(void action_enabled_changed(const Glib::ustring& action_name, bool enabled),
g_action_group_action_enabled_changed)
+
+ //TODO: Add templated method, renaming this to action_state_changed_variant).
_WRAP_METHOD(void action_state_changed (const Glib::ustring& action_name, const Glib::VariantBase& state),
g_action_group_action_state_changed)
_WRAP_SIGNAL(void action_added(const Glib::ustring& action_name), "action-added")
diff --git a/gio/src/simpleaction.hg b/gio/src/simpleaction.hg
index f5dfb93..202f2e6 100644
--- a/gio/src/simpleaction.hg
+++ b/gio/src/simpleaction.hg
@@ -125,6 +125,8 @@ public:
static Glib::RefPtr<SimpleAction> create_radio_integer(const Glib::ustring& name, gint32 inital_state);
_WRAP_METHOD(void set_enabled(bool enabled = true), g_simple_action_set_enabled)
+
+ //TODO: Add templated version of this, renaming this to set_state_variant(), like Action::change_state()?
_WRAP_METHOD(void set_state(const Glib::VariantBase& value), g_simple_action_set_state)
_WRAP_PROPERTY("enabled", bool)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]