[gnome-music: 1/3] Fix crash when a track isn't loaded on ArtistAlbumWidget.get_songs



commit c4566b9b2f60e1762c6fb90258bab441dbe0b327
Author: Felipe Borges <felipe10borges gmail com>
Date:   Mon Aug 5 09:04:05 2013 -0300

    Fix crash when a track isn't loaded on ArtistAlbumWidget.get_songs
    
    If you switch very fast from the 'Albuns' view to the 'Artists'
    view, it crashes. Apparently it happens when a track is not loaded
    yet, so methods such as get_url() return NoneType which cannot be
    converted to 'str' implicitly. It needs to be converted to 'str'
    explicitly to be used on logging.debug.

 gnomemusic/widgets.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/gnomemusic/widgets.py b/gnomemusic/widgets.py
index 09b7ae3..990bd0b 100644
--- a/gnomemusic/widgets.py
+++ b/gnomemusic/widgets.py
@@ -514,7 +514,7 @@ class ArtistAlbumWidget(Gtk.HBox):
                 song_widget.title = ui.get_object("title")
 
                 try:
-                    self.player.discoverer.discover_uri(track.get_url())
+                    self.player.discoverer.discover_uri(str(track.get_url()))
                     self.model.set(itr,
                                    [0, 1, 2, 3, 4, 5],
                                    [title, "", "", False,
@@ -530,7 +530,7 @@ class ArtistAlbumWidget(Gtk.HBox):
                                         self.track_selected)
 
                 except:
-                    print("failed to discover url " + track.get_url())
+                    logging.debug("failed to discover url " + str(track.get_url()))
                     self.model.set(itr, [0, 1, 2, 3, 4, 5],
                                    [title, "", "", True,
                                     ERROR_ICON_NAME, track])


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]